Fiddle: gas improvement for fee tracker#12
Merged
Conversation
krishan711
changed the base branch from
main
to
fix-vault-token-fee-conversion
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes FeeTracker position storage by packing per-(wallet,vault) cost basis and share balances into a single storage slot, aiming to reduce gas costs during deposits/withdrawals while keeping existing getter access patterns.
Changes:
- Introduce a packed
VaultPositionstruct (uint128 costBasis,uint128 shares) and store it in a single nested mapping. - Update deposit/withdraw accounting to read/write via the packed struct.
- Preserve the previous external ABI by reintroducing
agentVaultCostBasis(...)/agentVaultShares(...)as explicit view functions.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test/mocks/MockFeeTracker.sol | Mirrors the packed vault-position storage in the mock and updates position tracking logic/getters. |
| src/FeeTracker.sol | Packs vault position tracking into a struct mapping and updates all position accounting/getters accordingly. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.