Fiddle: deploy to production#13
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Foundry deployment and timelock-operation scripts for a production deploy, including new production addresses and support for timelock predecessor dependencies when sequencing configuration operations.
Changes:
- Switch deployment script defaults to production settings (new deterministic salt,
TESTING_MODE=false, 4-day timelock delay) and parameterize admin addresses viaMULTISIG_ADMIN_ADDRESS. - Extend
RegisterVaultandAddSellableTokensscripts to accept a timelockpredecessorso operations can be chained safely. - Refresh production
deployments.json, adddeployments-testing.json, and commit broadcast artifacts/README cleanup.
Reviewed changes
Copilot reviewed 58 out of 104 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| script/RegisterVault.s.sol | Adds predecessor support when scheduling/executing timelock ops for vault adapter registration. |
| script/Deploy.s.sol | Moves script defaults to production deployment settings and introduces multisig admin env wiring. |
| script/AddSellableTokens.s.sol | Adds predecessor support when scheduling/executing timelock ops for allowlisting sellable tokens. |
| deployments.json | Updates production deployed contract addresses. |
| deployments-testing.json | Adds a separate testing deployment address snapshot. |
| broadcast/RegisterVault.s.sol/8453/*.json | Adds many RegisterVault broadcast run artifacts for chain 8453. |
| broadcast/RegisterVault.s.sol/8453/dry-run/*.json | Adds dry-run artifacts. |
| README.md | Removes temporary local testing instructions block. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.