Skip to content

Fiddle: deploy to production#13

Merged
krishan711 merged 2 commits into
mainfrom
deployprod
Mar 16, 2026
Merged

Fiddle: deploy to production#13
krishan711 merged 2 commits into
mainfrom
deployprod

Conversation

@krishan711
Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings March 16, 2026 18:23
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Foundry deployment and timelock-operation scripts for a production deploy, including new production addresses and support for timelock predecessor dependencies when sequencing configuration operations.

Changes:

  • Switch deployment script defaults to production settings (new deterministic salt, TESTING_MODE=false, 4-day timelock delay) and parameterize admin addresses via MULTISIG_ADMIN_ADDRESS.
  • Extend RegisterVault and AddSellableTokens scripts to accept a timelock predecessor so operations can be chained safely.
  • Refresh production deployments.json, add deployments-testing.json, and commit broadcast artifacts/README cleanup.

Reviewed changes

Copilot reviewed 58 out of 104 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
script/RegisterVault.s.sol Adds predecessor support when scheduling/executing timelock ops for vault adapter registration.
script/Deploy.s.sol Moves script defaults to production deployment settings and introduces multisig admin env wiring.
script/AddSellableTokens.s.sol Adds predecessor support when scheduling/executing timelock ops for allowlisting sellable tokens.
deployments.json Updates production deployed contract addresses.
deployments-testing.json Adds a separate testing deployment address snapshot.
broadcast/RegisterVault.s.sol/8453/*.json Adds many RegisterVault broadcast run artifacts for chain 8453.
broadcast/RegisterVault.s.sol/8453/dry-run/*.json Adds dry-run artifacts.
README.md Removes temporary local testing instructions block.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread script/Deploy.s.sol
Comment thread broadcast/RegisterVault.s.sol/8453/run-latest.json
@krishan711 krishan711 merged commit 0e39ed8 into main Mar 16, 2026
1 check passed
@krishan711 krishan711 deleted the deployprod branch March 16, 2026 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants