Expose tiny-http's chunked_threshold value to the RequestData struct#292
Open
jsrobson10 wants to merge 3 commits intotomaka:masterfrom
Open
Expose tiny-http's chunked_threshold value to the RequestData struct#292jsrobson10 wants to merge 3 commits intotomaka:masterfrom
jsrobson10 wants to merge 3 commits intotomaka:masterfrom
Conversation
Author
|
I've just merged the upstream changes into this PR and verified that all tests still pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Changes
These changes allow the chunked_threshold value in tiny-http to be overridden per request.
This was achieved by adding an extra field to
RequestData. I would have liked to add it toRequestinstead, butRequestDatahas private fields which means the changes could be made without causing downstream breakage.Examples
Force the
Content-Lengthheader to always be used: