Skip to content

Error with expire when use custom cacheKey #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
max-konin wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Error with expire when use custom cacheKey #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c87e831
Update index.js
max-konin Dec 16, 2016
bf5c470
Update caching-test.js
max-konin Dec 16, 2016
752a5d9
Merge pull request #1 from max-konin/not-cache-3xx-res
max-konin Dec 18, 2016
fd55835
Update index.js
max-konin Jan 9, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,14 +58,14 @@ class RedisCache {
let statusCodeStr = statusCode && (statusCode + '');

if (statusCodeStr && statusCodeStr.length &&
(statusCodeStr.charAt(0) === '4' || statusCodeStr.charAt(0) === '5')) {
(statusCodeStr.charAt(0) === '4' || statusCodeStr.charAt(0) === '5' || statusCodeStr.charAt(0) === '3')) {
res();
return;
}

this.client.multi()
.set(key, body)
.expire(path, this.expiration)
.expire(key, this.expiration)
.exec(err => {
if (err) {
rej(err);
Expand Down
9 changes: 9 additions & 0 deletions test/caching-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,15 @@ describe('caching tests', function() {
expect(mockRedis['/']).to.be.undefined;
});
});

it('does not cache 3xx error responses', function() {
let body = '<body>Redirect to </body>';
let mockResponse = { statusCode: 301 };

return cache.put('/', body, mockResponse).then(() => {
expect(mockRedis['/']).to.be.undefined;
});
});
});

describe('custom keys tests', function() {
Expand Down