Bug fix in cl-format#1
Open
bwanab wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Tom, I hope I'm doing this right :)
I was using cl-format on some big numbers (financial software) and found a strange bug:
(cl-format nil "~12,3F" 22222222.6674)
"22222222.667"
user> (cl-format nil "~12,3F" 22222222.6675)
; Evaluation aborted....
It turns out that when the numbers are big enough, when it tries to do the conversion using Integer/valueOf, the values are too large. In my fix, I just changed it to Long/valueOf and it fixes it.
Best regards and thanks for contributing this nice package.
Bill Allen