feat: split editor pane#632
Merged
Merged
Conversation
- Add EditorPane class that holds one editor at a time with its own placeholder - Replace direct editor grid placement in EditorsManager with a PanedWindow containing EditorPanes - Update Tab.select/deselect to route editor placement through the active pane - Add Split Editor entry to editors bar menu for discoverability - Toggle split via Ctrl+\ (keybinding already existed)
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…dWindow reparenting
pane.master is set at widget creation and never changes, but after a split
the pane gets reparented into a nested PanedWindow. This caused a crash
('is not in list') on subsequent splits and close_pane calls.
Added _find_parent_pw / _find_parent_pw_recursive to walk the PanedWindow
tree and find the actual parent that contains the given EditorPane.
config.py still referenced self.editorsmanager.editorsbar.show_breadcrumbs() which no longer exists. Breadcrumbs are now per-pane; iterate all panes.
pip is not available in uv-managed environments, causing a crash on startup. Also added FileNotFoundError to the exception handler.
…ttons param - Remove self.editorsbar and self.breadcrumbs from GUIManager (now per-pane) - Rename create_buttons(editorsbar) -> create_buttons(parent) in BaseEditor
- Add split_editor_vertical command - change_tab_forward/back now route through editorsmanager instead of editorsbar - open_editors uses editorsmanager.switch_tabs and close_editor_by_path directly
Each EditorPane now owns its own tab bar (with tabs + right-aligned action buttons) and breadcrumbs. Tab bar auto-hides when empty. Pane auto-closes when the last tab is closed (if more than one pane exists). EditorsBar is stripped of tab management — it retains only action-container compatibility for legacy callers. Tab's master is now EditorPane instead of EditorsBar. Adds 'Split Editor Vertical' and 'Close Split' menu entries.
_find_parent_pw only recursed into PanedWindow children of root_pw, missing the case where the target EditorPane is a direct child of root_pw (initial unsplit state). This caused _split_pane to silently return without doing anything.
nametowidget identity checks (child is pane) can fail in edge cases due to Tkinter proxy object behavior. Switch to iterating all nested PanedWindows and comparing pane path strings directly with panes(), which is deterministic and sidesteps the identity issue.
First check if pane_path is a direct child of root_pw via string comparison, then fall back to recursion with both identity (is) and string (==) checks. This handles both the initial unsplit state and deeply nested splits.
On this system (tkinterDnD), PanedWindow.panes() returns widget objects instead of path strings. All string-based comparisons (in, .index, ==) silently failed. Switch to identity (is) and isinstance checks throughout.
…collapses grid state)
…t run after _equalize_pw)
Key changes: - Replace reparenting with destroy-and-recreate for nested splits - Editors survive pane destruction (mastered by EditorsManager) - Every EditorPane is created fresh with its final parent - No widget path changes, no grid corruption, no stale sashes - Flat split unchanged (no reparenting needed) Adds blog/split-editor-journey.md documenting the journey.
- Each pane's plus/split buttons now operate on that pane (not active_pane) - Split preserves original editor's exists and showpath attributes so untitled editors don't get breadcrumbs on their split sibling
- Add new_like() to BaseEditor/Editor for cloning editors during split - Non-Editor editors (e.g. BrowserEditor) use reparenting instead of destroy-and-recreate, preserving WebView2 native handles - Sibling creation falls back to new_like() when no file path exists - Both flat and nested paths support new_like()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the split editor feature (Ctrl+\ to toggle). EditorsManager now uses a PanedWindow with EditorPane instances instead of placing editors directly. Each pane shows one editor at a time, and clicking a tab routes the editor to the currently active pane.