WEBP support and fopen optimization#10
Closed
sillydong wants to merge 1 commit into
Closed
Conversation
sillydong
commented
Jun 1, 2015
sillydong
commented
- Enable WEBP type image
- Add timeout and refer to fopen to avoid time waste and blocked by Hotlink Protection
2. Add timeout and refer to fopen to avoid time waste and blocked by Hotlink Protection
Owner
|
@sillydong thanks for this, unfortunately the diff shows every line as changed so I can't properly review this. Please submit a PR with only the lines of code that are required to change 😄 |
|
@sillydong do you have time to work on that one? |
|
You can ignore whitespace/line-ending things: https://github.com/tommoor/fastimage/pull/10/files?w=1 |
Author
|
Sorry I just noticed this notification, I will reedit my code and send pull request again |
Author
|
see #12 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.