fix(app): truncate long project breadcrumbs - #117
Open
cunninghamcard-bit wants to merge 1 commit into
Open
Conversation
tommy0103
reviewed
Aug 28, 2026
tommy0103
left a comment
Owner
There was a problem hiding this comment.
Verification cross-check from a maintainer machine (macOS, Electron 43.2.0): I built this head (f5dd971) and ran electron-session-virtualization.mjs 3 times — 3/3 fully green (55/55 assertions each).
On the patchReads: 0 baseline failure mentioned in the description: I could not reproduce it here — 5/5 suite runs pass on code identical to origin/main in renderer/preload. It appears environment/timing-specific rather than a stable main-branch defect (the cold-open patch-read assertion is known to be timing-sensitive). Nothing suggests this PR regresses the suite; the change is confined to the toolbar breadcrumb, which this suite never exercises. LGTM on the verification front.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reproduction
A long project name can consume the toolbar width and collide with the source filter and search controls.
Root cause
The project breadcrumb had no shrink or truncation boundary, while the source-filter control was allowed to shrink.
Fix
title..breadcrumbcontainer unchanged, so SessionDetail, MemoryDetail, and RecapDetail title crumbs are not clipped.Verification
npm test: 546/546 passed.npm run typecheck: root and app tsconfigs passed (2/2).npm run lint: 0 errors, 9 existing warnings.npm run test:electron:all: 4/5 suites passed locally;electron-session-virtualization.mjsfailed macOS hidden-window wheel/timing assertions. The unchangedorigin/mainbaseline also produced 4/5 in the same environment (virtualization failed withpatchReads: 0). No test assertion was changed or loosened.Scope
This PR only addresses project breadcrumb layout. The source-filter outside-click behavior remains in #116.