Repository navigation
Sprint 4 PR 4.6b — integration tests for holidays router - #238
Merged
Merged
Conversation
Summary: Continues PR 4.6b file-by-file revival of the integration tier. Adds real-HTTP coverage for /api/v1/holidays: single-create, admin bulk import (including within-batch de-dup), list envelope + org scoping, get, update, delete. Changed files: - tests/integration/test_holidays.py (new) — 17 tests across create/bulk/list/get/update/delete, covering: admin gate on writes, volunteer can read list, cross-org 403 on both create and list, bulk reports created/skipped/errors correctly with duplicate dates in the same request, envelope shape, 404s on missing ids. Validation: - poetry run pytest tests/integration/test_holidays.py -v — 17 passed - poetry run black tests/integration/test_holidays.py — clean - poetry run ruff check tests/integration/test_holidays.py — clean - No OpenAPI snapshot refresh (no endpoints added or changed). Follow-ups: - Remaining integration files to revive: resources, recurring_events, assignments, audit, analytics, calendar, password_reset, solutions, solver, people, webhooks.
tomqwu
marked this pull request as ready for review
July 19, 2026 13:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Continues Sprint 4 PR 4.6b (file-by-file revival of the
tests/integration/tier). Adds a production-endpoint integration file that drives the/holidaysrouter over real HTTP against the session-scoped uvicornapi_serverfixture, including the admin-only bulk-import path.Coverage
tests/integration/test_holidays.py— 17 tests covering:POST /holidays/— success, admin gate (volunteer 403), cross-org 403/404POST /holidays/bulk— success (3 rows created), within-batch duplicate date reported as skipped+error, admin gateGET /holidays/— envelope shape (items/total/limit/offset), org scoping, volunteer can read, cross-org 403GET /holidays/{id}— success + 404PUT /holidays/{id}— label update, admin gate, 404DELETE /holidays/{id}— success + 404, admin gateValidation
poetry run pytest tests/integration/test_holidays.py -v— 17 passedpoetry run black tests/integration/test_holidays.py— cleanpoetry run ruff check tests/integration/test_holidays.py— cleanNo OpenAPI snapshot refresh (no endpoints added or changed).
Notes
errors[0].row == 1and bothcreated==1, skipped==1, locking in the exact contract.Follow-ups
Remaining routers still to revive under
tests/integration/: resources, recurring_events, assignments, audit, analytics, calendar, password_reset, solutions, solver, people, webhooks.Generated by Claude Code