Repository navigation
Sprint 4 PR 4.6b — integration tests for resources router - #239
Merged
Merged
Conversation
Summary: Continues PR 4.6b file-by-file revival of the integration tier. Adds real-HTTP coverage for /api/v1/resources: create with duplicate/ cross-org guards, list envelope with type filter, get, update, delete (including the 409-if-referenced-by-Event guard). Changed files: - tests/integration/test_resources.py (new) — 17 tests across create/list/get/update/delete, covering: admin gate on writes, volunteer can read, cross-org 403, duplicate id 409, delete-with- referencing-event 409 (the router's referential-integrity guard), envelope shape, 404 on missing ids. Validation: - poetry run pytest tests/integration/test_resources.py -v — 17 passed - poetry run black tests/integration/test_resources.py — clean - poetry run ruff check tests/integration/test_resources.py — clean - No OpenAPI snapshot refresh (no endpoints added or changed). Follow-ups: - Remaining integration files to revive: recurring_events, assignments, audit, analytics, calendar, password_reset, solutions, solver, people, webhooks.
tomqwu
marked this pull request as ready for review
July 19, 2026 13:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Continues Sprint 4 PR 4.6b (file-by-file revival of the
tests/integration/tier). Adds a production-endpoint integration file that drives the/resourcesrouter over real HTTP against the session-scoped uvicornapi_serverfixture. Locks in the admin gate, org tenancy, the duplicate-id 409 guard, and the referential-integrity 409 that fires when an event still references the resource.Coverage
tests/integration/test_resources.py— 17 tests covering:POST /resources/— success, admin gate (volunteer 403), duplicate id 409, cross-org 403/404GET /resources/— envelope shape, org scoping,type=equipmentfilter, volunteer read allowed, cross-org 403GET /resources/{id}— success + 404PUT /resources/{id}— capacity + location update, admin gate, 404DELETE /resources/{id}— success + 404, admin gate, and the 409 when an Event still references the resourceValidation
poetry run pytest tests/integration/test_resources.py -v— 17 passedpoetry run black tests/integration/test_resources.py— cleanpoetry run ruff check tests/integration/test_resources.py— cleanNo OpenAPI snapshot refresh (no endpoints added or changed).
Notes
test_delete_referenced_by_event_409creates a real Event withresource_idset, then attempts a delete — locks in the router's referential-integrity guard (not just a schema-level FK check).datetime.now(UTC) + timedelta(days=25)for the event window to avoid clashing with other integration tests that also use future dates.Follow-ups
Remaining routers still to revive under
tests/integration/: recurring_events, assignments, audit, analytics, calendar, password_reset, solutions, solver, people, webhooks.Generated by Claude Code