Repository navigation
Synchronize 3D architecture stories with audio (v1.20.0) - #42
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Playing an architecture explanation previously paused its 3D story. All four scenarios now use the recording as their single clock: the spoken section, component highlights, arrows and captions advance together. Story controls seek, pause, replay and change the same audio; inspection pauses it and Explore without audio restores the original walkthrough.
The 24 visual sections use exact caption anchors and grouped focus where the recording discusses multiple components. Denial never invokes a tool, and the failed-proof story stays on hold while narration describes a conditional passing alternative. Reduced motion retains static highlights, and changed captions fall back to a static overview. Narration can begin before model loading finishes; paused scenes redraw only when the view changes, and resuming clears the previous inspection highlight.
Validation: Chromium and WebKit with actual MP3s across all 24 sections, native playback boundaries, packet movement, pause/seek/speed/replay, final stop, early playback during model loading, inspection, responsive controls and invalid-caption fallback; existing 3D checks including idle rendering and camera interaction; all 109 presenter notes and 16 pages; all nine 2D diagrams and 78 cues; site/publication checks; release packaging tests. CI includes the new audio-story regression suite.
v1.20.0 updates the shared release record and narration bundle. Accepted recordings and PDF editions remain unchanged. Original renderer/style snapshots preserve the existing silent film's input hashes; the film was not regenerated.