Repository navigation
Prevent overlapping narration across presentations (v1.21.1) - #44
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two open presentation pages could narrate at the same time. Starting a second player now takes audio focus across same-origin tabs/windows, page guides, native media controls and nested embedded decks. The previous player stays paused, including during buffering and the two-second gap before auto-next.
The shared controller cancels stale transitions, ignores delayed play events from cancelled requests and orders cross-window claims. BroadcastChannel uses storage events as a fallback. Existing recordings, captions, diagrams and slide/PDF editions are unchanged; existing presentation tabs need a refresh to load the update.
Validation: reproduced the previous overlap with actual recordings in Chromium and WebKit, then confirmed the fix. Added CI coverage for cross-page and frame handoffs, simultaneous requests, cancelled loading, delayed native events, duplicate initialization, native controls, pending slide transitions, storage-only fallback and no automatic resumption. Existing player and shipped-recording checks pass; the full publication suite runs on this PR. Release metadata and narration documentation are updated to v1.21.1.