Repository navigation
Improve 3D platform camera proportions and framing (v1.21.2) - #45
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The platform's low, oblique camera angle made its depth look flattened, and its tight fixed framing could crowd the scene edges. The interactive demo now starts from a higher, more front-facing angle and fits the actual model bounds with one proportional scale and clear margins at each viewport shape. Optional camera motion stays at the same elevated angle.
Reset view now restores zoom, center and angle and clears residual orbit damping. Model geometry, accepted audio/captions and the original film assets are unchanged. The generated Three.js bundle, site version and release notes are updated to v1.21.2.
Validation: new Chromium and WebKit tests check the loaded model's projected bounds and aspect ratio at five viewport shapes, guided camera motion, zoom/orbit reset and reduced motion. Existing 3D browser checks and all 24 narrated sections across four scenarios pass. Visually reviewed desktop and mobile captures; bundle/model/film provenance, site links, PDF editions and release preparation checks pass. The full publication suite runs on the PR.