Skip to content

Let subtitles use the available player width (v1.24.1) - #59

Merged
tomqwu merged 1 commit into
mainfrom
codex/subtitle-natural-wrap
Sep 10, 2026
Merged

tomqwu merged 1 commit into
mainfrom
codex/subtitle-natural-wrap

Conversation

@tomqwu

@tomqwu tomqwu commented Sep 10, 2026

Copy link
Copy Markdown
Owner

The custom subtitle players preserved line breaks authored for video captions, so short cues occupied two lines even in a wide blue bar. Both player styles now collapse those breaks for display and wrap to their available width. Slide captions also use the full panel width; page captions stay vertically centered.

Validated the reported caption at 23 seconds with the shipped recording in Chromium and WebKit: one line at 1440px and natural two-line wrapping at 390px, in both page and slide players, with no clipping. Rendered screenshots and site/publication checks pass; all 167 narration destinations retain their reviewed content. This CSS-only player patch retains the v1.24.0 PDFs and unchanged audio/caption timing. Publication remains gated by the full CI browser groups.

@tomqwu
tomqwu merged commit 6388f0a into main Sep 10, 2026
1 check passed

tomqwu commented Sep 10, 2026

Copy link
Copy Markdown
Owner Author

Published and verified in v1.24.1. The main workflow passed the build, all five browser groups, deployment and release.

Hosted checks used the reported recording at 23 seconds in both Chromium and WebKit. The caption renders on one line at 1440px and wraps naturally to two at 390px, in both slide and page players, with no clipping. All 20 release digests, 23 served files and eight page editions were verified. Audio, VTT text/timing and the v1.24.0 PDFs are unchanged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant