Repository navigation
Let subtitles use the available player width (v1.24.1) - #59
Merged
Merged
Conversation
Owner
Author
|
Published and verified in v1.24.1. The main workflow passed the build, all five browser groups, deployment and release. Hosted checks used the reported recording at 23 seconds in both Chromium and WebKit. The caption renders on one line at 1440px and wraps naturally to two at 390px, in both slide and page players, with no clipping. All 20 release digests, 23 served files and eight page editions were verified. Audio, VTT text/timing and the v1.24.0 PDFs are unchanged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The custom subtitle players preserved line breaks authored for video captions, so short cues occupied two lines even in a wide blue bar. Both player styles now collapse those breaks for display and wrap to their available width. Slide captions also use the full panel width; page captions stay vertically centered.
Validated the reported caption at 23 seconds with the shipped recording in Chromium and WebKit: one line at 1440px and natural two-line wrapping at 390px, in both page and slide players, with no clipping. Rendered screenshots and site/publication checks pass; all 167 narration destinations retain their reviewed content. This CSS-only player patch retains the v1.24.0 PDFs and unchanged audio/caption timing. Publication remains gated by the full CI browser groups.