Skip to content

add readme#1

Open
heart wants to merge 2 commits into
tomvanzummeren:masterfrom
heart:master
Open

add readme#1
heart wants to merge 2 commits into
tomvanzummeren:masterfrom
heart:master

Conversation

@heart

@heart heart commented Oct 20, 2017

Copy link
Copy Markdown

i help you to write a README

@tomvanzummeren tomvanzummeren left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating a screenshot! But I see a little bit of the background behind the Simulator. Please create a new screenshot using Cmd + Shift + 4, followed by pressing the spacebar and then click the Simulator window. Now you get a much nicer screenshot!

let datePicker = TZDatePicker(dateComponents: dateComponents)
datePicker.onValueChanged = {
dateComponents in
dateComponents

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all, thank you very much for writing the README for me!! Now for the review: why did you add this line? Please remove it.

Comment thread README.md
@@ -1 +1,41 @@
# TZDatePicker

is a simple DatePicker that easy to use

@tomvanzummeren tomvanzummeren Oct 20, 2017

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a good sentence and also not the reason I created this pod. I created it because I wanted a date picker with an optional year. Please change this into "This is a replacement for the UIDatePicker, which allows the year to be optional."

Comment thread README.md

## Installation

SwiftTween is available through [CocoaPods](http://cocoapods.org). To install

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SwiftTeen?

Comment thread README.md
datePicker.onValueChanged = {
dateComponents in

print( dateComponents.description )

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove empty line and change the print() into:
// Handle changed dateComponents

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants