gilded-rose-april-2-2022

refactoring/gildedrose/js/app/aged-brie-quality-updater.ts

@@ -0,0 +1,17 @@
+import {QualityUpdater} from "@/quality-updater";
+import {Item} from "@/item";
+
+export class AgedBrieQualityUpdater implements QualityUpdater {
+    update(item: Item): Item {
+        return this.updateQualityForAgeBrie(item);
+    }
+
+    private updateQualityForAgeBrie(item: Item) {
+        let updatedQuality = item.increaseQuality();
+        let updatedSellIn = item.sellIn - 1;
+        if (updatedSellIn < 0) {
+            updatedQuality = updatedQuality.increaseQuality();
+        }
+        return new Item(item.name, updatedSellIn, updatedQuality.quality);
+    }
+}

refactoring/gildedrose/js/app/backstage-pass-quality-updater.ts

@@ -0,0 +1,24 @@
+import {QualityUpdater} from "@/quality-updater";
+import {Item} from "@/item";
+import {NonNegativeWithCeilingQuality} from "@/non-negative-with-ceiling-quality";
+
+export class BackstagePassQualityUpdater implements QualityUpdater {
+    update(item: Item): Item {
+        return this.updateQualityBackstagePasses(item);
+    }
+
+    private updateQualityBackstagePasses(item: Item) {
+        let updateQuality = item.increaseQuality();
+        if (item.sellIn < 11) {
+            updateQuality = updateQuality.increaseQuality();
+        }
+        if (item.sellIn < 6) {
+            updateQuality = updateQuality.increaseQuality();
+        }
+        let updatedSellIn = item.sellIn - 1;
+        if (updatedSellIn < 0) {
+            updateQuality = NonNegativeWithCeilingQuality.zero();
+        }
+        return new Item(item.name, updatedSellIn, updateQuality.quality);
+    }
+}

refactoring/gildedrose/js/app/default-item-quality-updater.ts

@@ -0,0 +1,17 @@
+import {QualityUpdater} from "@/quality-updater";
+import {Item} from "@/item";
+
+export class DefaultItemQualityUpdater implements QualityUpdater {
+    update(item: Item): Item {
+        return this.updateQualityForDefaultItem(item);
+    }
+
+    private updateQualityForDefaultItem(item: Item) {
+        let updatedQuality = item.decreaseQuality();
+        let updatedSellIn = item.sellIn - 1;
+        if (updatedSellIn < 0) {
+            updatedQuality = updatedQuality.decreaseQuality();
+        }
+        return new Item(item.name, updatedSellIn, updatedQuality.quality);
+    }
+}

refactoring/gildedrose/js/app/gilded-rose.ts

@@ -1,69 +1,35 @@
-export class Item {
-  name: string;
-  sellIn: number;
-  quality: number;
-
-  constructor(name, sellIn, quality) {
-    this.name = name;
-    this.sellIn = sellIn;
-    this.quality = quality;
-  }
-}
+import {QualityUpdater} from "@/quality-updater";
+import {BackstagePassQualityUpdater} from "@/backstage-pass-quality-updater";
+import {AgedBrieQualityUpdater} from "@/aged-brie-quality-updater";
+import {SulfurasQualityUpdater} from "@/sulfuras-quality-updater";
+import {DefaultItemQualityUpdater} from "@/default-item-quality-updater";
+import {Item} from "@/item";
 
 export class GildedRose {
-  items: Array<Item>;
+    items: Array<Item>;
 
-  constructor(items = [] as Array<Item>) {
-    this.items = items;
-  }
+    constructor(items = [] as Array<Item>) {
+        this.items = items;
+    }
+
+    updateQuality() {
+        this.items = this.items.map(item => this.createQualityUpdater(item.name).update(item));
+        return this.items;
+    }
 
-  updateQuality() {
-    for (let i = 0; i < this.items.length; i++) {
-      if (this.items[i].name != 'Aged Brie' && this.items[i].name != 'Backstage passes to a TAFKAL80ETC concert') {
-        if (this.items[i].quality > 0) {
-          if (this.items[i].name != 'Sulfuras, Hand of Ragnaros') {
-            this.items[i].quality = this.items[i].quality - 1
-          }
+    private createQualityUpdater(name: string) : QualityUpdater{
+        if (name == 'Aged Brie') {
+            return new AgedBrieQualityUpdater();
         }
-      } else {
-        if (this.items[i].quality < 50) {
-          this.items[i].quality = this.items[i].quality + 1
-          if (this.items[i].name == 'Backstage passes to a TAFKAL80ETC concert') {
-            if (this.items[i].sellIn < 11) {
-              if (this.items[i].quality < 50) {
-                this.items[i].quality = this.items[i].quality + 1
-              }
-            }
-            if (this.items[i].sellIn < 6) {
-              if (this.items[i].quality < 50) {
-                this.items[i].quality = this.items[i].quality + 1
-              }
-            }
-          }
+
+        if (name == 'Backstage passes to a TAFKAL80ETC concert') {
+            return new BackstagePassQualityUpdater();
         }
-      }
-      if (this.items[i].name != 'Sulfuras, Hand of Ragnaros') {
-        this.items[i].sellIn = this.items[i].sellIn - 1;
-      }
-      if (this.items[i].sellIn < 0) {
-        if (this.items[i].name != 'Aged Brie') {
-          if (this.items[i].name != 'Backstage passes to a TAFKAL80ETC concert') {
-            if (this.items[i].quality > 0) {
-              if (this.items[i].name != 'Sulfuras, Hand of Ragnaros') {
-                this.items[i].quality = this.items[i].quality - 1
-              }
-            }
-          } else {
-            this.items[i].quality = this.items[i].quality - this.items[i].quality
-          }
-        } else {
-          if (this.items[i].quality < 50) {
-            this.items[i].quality = this.items[i].quality + 1
-          }
+
+        if (name == 'Sulfuras, Hand of Ragnaros') {
+            return new SulfurasQualityUpdater();
         }
-      }
-    }
 
-    return this.items;
-  }
+        return new DefaultItemQualityUpdater();
+    }
 }

refactoring/gildedrose/js/app/item.ts

@@ -0,0 +1,29 @@
+import {NonNegativeWithCeilingQuality} from "@/non-negative-with-ceiling-quality";
+
+export class Item {
+    name: string;
+    sellIn: number;
+    quality: NonNegativeWithCeilingQuality;
+
+    constructor(name, sellIn, quality) {
+        this.name = name;
+        this.sellIn = sellIn;
+        this.quality = new NonNegativeWithCeilingQuality(quality);
+    }
+
+    public increaseQuality() {
+        return this.quality.increaseQuality();
+    }
+
+    public toString() {
+        return `{"name":"${this.name}","sellIn":${this.sellIn},"quality":${this.quality.quality}}`;
+    }
+
+    public decreaseQuality() {
+        return this.quality.decreaseQuality();
+    }
+
+    public qualityAmount() {
+        return this.quality.quality;
+    }
+}

refactoring/gildedrose/js/app/non-negative-with-ceiling-quality.ts

@@ -0,0 +1,25 @@
+export class NonNegativeWithCeilingQuality {
+    quality: number;
+
+    constructor(quality) {
+        this.quality = quality;
+    }
+
+    public increaseQuality() {
+        if (this.quality < 50) {
+            return new NonNegativeWithCeilingQuality(this.quality + 1);
+        }
+        return new NonNegativeWithCeilingQuality(this.quality);
+    }
+
+    static zero() {
+        return new NonNegativeWithCeilingQuality(0);
+    }
+
+    public decreaseQuality() {
+        if (this.quality > 0) {
+            return new NonNegativeWithCeilingQuality(this.quality - 1);
+        }
+        return new NonNegativeWithCeilingQuality(this.quality);
+    }
+}

refactoring/gildedrose/js/app/quality-updater.ts

@@ -0,0 +1,5 @@
+import {Item} from "@/item";
+
+export interface QualityUpdater {
+    update(item: Item): Item;
+}

refactoring/gildedrose/js/app/sulfuras-quality-updater.ts

@@ -0,0 +1,8 @@
+import {QualityUpdater} from "@/quality-updater";
+import {Item} from "@/item";
+
+export class SulfurasQualityUpdater implements QualityUpdater {
+    update(item: Item): Item {
+        return new Item(item.name, item.sellIn, item.qualityAmount());
+    }
+}

refactoring/gildedrose/js/test/golden-master-text-test.ts

@@ -1,4 +1,5 @@
-import { Item, GildedRose } from '../app/gilded-rose';
+import { GildedRose } from '../app/gilded-rose';
+import {Item} from "@/item";
 
 const items = [
   new Item("+5 Dexterity Vest", 10, 20), //