Fix draft title issue

[leninhasda]

also added "." in css link to make it relative

[sarim]

Thanks for the fixes. But I think css ellipsis will look better here. What do you think?

[torifat]

@sarim 👍 I agree

[leninhasda]

I didn't know there was a css property for that!! :O
BTW if css can do the trick why do we need that title length checking? we can just send full text as title and let css do its job.

Let me know if i am missing or overthinking something. Thank you @sarim vai :)

[sarim]

Yes, that will work. But will that increase DOM memory consumption or shit like that? I don't know :| Maybe we can chop it to like 100 chars then use css ellipsis just to be sure.

[torifat]

Don't worry about memory for a mere title man 😄

[sarim]

Here title = content if we do that, imagine someone writes an essay :v

[leninhasda]

hahaha... :v i was just trying to imagine that :P
ok, i am adjusting it to 100 character then.
but may be for my version i will be making option to add custom title :D

[leninhasda]

actually don't even need to check for 100 characters. its already cutting out first line of the content which i think should do just fine

[torifat]

@sarim title ≠ content 😛

[sarim]

@leninhasda I think this will be better.

if (!!content && content.trim()) {
  return content.substr(0, titleLength);
}

Also can you change href="./css/main.css" to href="css/main.css" ? :)

[leninhasda]

updated @sarim vai

[sarim]

one last fix :P please add && content.trim() logic like my previous comment. Without it, if someone types only spaces, draft title becomes empty.

[torifat]

@sarim

if (!!content && content.trim()) {
  return content.substr(0, titleLength); // Here content is not trimmed :)
}

[sarim]

Yes i noticed that, but spaces won't be space when rendered in html :P

[leninhasda]

ahh.. should have noticed that, stupid mistake on my end :(

i have a question, i can't seem to figure it out which gulp plugin is concating js files and also renaming (both js & css) files to "app"? gulp-rev is adding the hash part, but what about "app" part?

[torifat]

@leninhasda uglify is doing the minification & concatenation 😄

[leninhasda]

i thought uglify only minifies js files & so i use gulp-concate for concatenation :-|