get_info memleak fix: cache exception string only #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* get_info(): Cache only the exception message * Create fresh exceptions * No traceback accumulation, no memory leak, cleaner code Caching the exception objects for `address` and `fingerprint` get_info() params and re-raising them creates an accumulation of python frame and traceback objects, essentially creating a memory leak with observable linear growth of memory usage over time. This appears to be an anti-pattern and prevents the python garbage collector from collecting these exceptions and also creates references to other objects, preventing collection. Instead of caching the entire exception object, this commit just caches the exception string, ensuring no unintentional references are created that accumulate frame, tracebacks, or other application objects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caching the exception objects for
addressandfingerprintget_info() params and re-raising them creates an accumulation of python frame and traceback objects, essentially creating a memory leak with observable linear growth of memory usage over time.This appears to be an anti-pattern and prevents the python garbage collector from collecting these exceptions and also creates references to other objects, preventing collection.
Instead of caching the entire exception object,
this commit just caches the exception string,
ensuring no unintentional references are created
that accumulate frame, tracebacks, or other application objects.
see torproject/nyx#52