Skip to content

fix: tier 1 security & stability patches (RUSTSEC + agent panic + rbw edit) - #2

Merged
torreirow merged 2 commits into
mainfrom
feat/tier1-security-stability
Jul 31, 2026
Merged

fix: tier 1 security & stability patches (RUSTSEC + agent panic + rbw edit)#2
torreirow merged 2 commits into
mainfrom
feat/tier1-security-stability

Conversation

@torreirow

Copy link
Copy Markdown
Owner

Summary

  • RUSTSEC patches (upstream PR chore: patch for RUSTSEC-2026-0007 and RUSTSEC-2026-0049  doy/rbw#325): Cargo.lock-only bumps to clear active advisories — bytes 1.11.0→1.12.1 (RUSTSEC-2026-0007) and rustls-webpki 0.103.8→0.103.13 (RUSTSEC-2026-0049). No direct dependency changes.
  • Agent panic fix (upstream PR don't panic when sending error response to disconnected client doy/rbw#332): Replace .unwrap() with log::warn!() in the agent's error-send path. When a client disconnects mid-pinentry the agent no longer silently crashes with an opaque "EOF while parsing" error on the client side.
  • Consistent client version header (upstream PR Fix 'rbw edit' failure due to client version header doy/rbw#328 + extension): Add BITWARDEN_CLIENT_VERSION constant and apply it to all request paths. The missing header on the cipher-update blocking client was causing rbw edit to fail with "Cannot edit item. Update to the latest version of Bitwarden." Also extended to our prelogin_blocking() and server_config() calls added in the rbw-doctor change.

Test plan

  • cargo check clean (done locally)
  • CI passes (build, clippy, test jobs)
  • rbw edit no longer returns "Cannot edit item" on a modern Bitwarden/Vaultwarden server
  • Agent stays running after client disconnects mid-pinentry (no silent panic in agent log)

- Bump bytes 1.11.0 → 1.12.1 (RUSTSEC-2026-0007) and
  rustls-webpki 0.103.8 → 0.103.13 (RUSTSEC-2026-0049),
  Cargo.lock only — no Cargo.toml changes (upstream PR doy#325)
- Replace .unwrap() with log::warn!() in agent error-send path so a
  broken pipe when the client disconnects mid-pinentry no longer
  silently panics the tokio task (upstream PR doy#332)
- Add BITWARDEN_CLIENT_VERSION constant to src/api.rs and apply it
  consistently across all request paths including the cipher-update
  blocking client that was causing "rbw edit" to fail (upstream PR doy#328);
  extended to our prelogin_blocking() and server_config() calls
@torreirow
torreirow merged commit c0a9499 into main Jul 31, 2026
@torreirow
torreirow deleted the feat/tier1-security-stability branch July 31, 2026 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant