feat: add getter/setter and inheritance support#46
Merged
WhiteKiwi merged 3 commits intoMar 12, 2026
Conversation
- Support decorators on getter and setter methods using descriptor-based approach - Support inherited decorated methods/getters/setters through prototype chain traversal - Add comprehensive tests for getter/setter and inheritance scenarios
Member
|
If both getter and setter exist, decorators may not work as expected. |
Contributor
Author
|
@WhiteKiwi Good point 👍 |
Contributor
Author
|
Hi @WhiteKiwi, Just a friendly ping on this PR. Would appreciate another look whenever you have time. Thanks! |
WhiteKiwi
approved these changes
Mar 12, 2026
Member
|
Thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
issue: #45
PR Checklist