cap/picv workspace claim leak - #176
Open
totallynotdavid wants to merge 2 commits into
Open
Conversation
totallynotdavid
commented
Sep 6, 2026
totallynotdavid
commented
Owner
- Release claims after cancellation
- Clean up completed workspaces
Cancelled workers can outlive their async waiter. Release claims acquired by background threads so later attempts are not blocked.
Completed jobs can leave checkpoints behind after workers finish. Include all terminal jobs in retention cleanup so stale workspaces do not accumulate.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| """Release a claim whose thread completed after its waiter was cancelled.""" | ||
| try: | ||
| claim, _resume = await claim_future | ||
| except BaseException: |
|
|
||
| task.cancel() | ||
| with pytest.raises(asyncio.CancelledError): | ||
| await task |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.