ci: use GitHub-hosted runners (org has no self-hosted runners registered) - #105
Merged
Merged
Conversation
… (org has none registered; every other city-core repo already uses github-hosted)
Switching to GitHub-hosted runners made CI actually execute for the first time, which surfaced a pre-existing failure in the Frontend job's `npm audit --audit-level=moderate` gate: 10 known advisories (1 critical vitest, high vite/ws/launch-editor, moderate react-router/markdown-it) that the never-scheduled CI had been silently hiding. Fix the deps rather than weakening the gate: - react-router-dom 7.15.0 -> 7.18.1 (patches GHSA-84g9-w2xq-vcv6 CSRF; exact pin held, minor bump within v7) - npm audit fix for the in-range/transitive advisories (vitest 3.2.6, patched vite/ws/launch-editor/markdown-it/linkify-it) Verified locally: npm audit --audit-level=moderate = 0 vulnerabilities, generate:types not stale, tsc+vite build clean, all 42 vitest tests pass (routed components exercise react-router 7.18). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Fixing the audit gate let CI reach the "Run vitest suite" step, which runs `npm test` = `vitest run … && playwright test e2e/skip-link-no-occlude.spec.ts` — an inline Playwright spec. But the workflow installed Chromium *after* that step, so it failed with "Executable doesn't exist". Moved the `npx playwright install chromium` step ahead of the vitest step; the later a11y and e2e steps reuse the same install. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
records-ai's CI required
runs-on: [self-hosted, linux, x64]but the CivicSuite org has ZERO self-hosted runners registered (org- and repo-level), so every records-ai job sits queued forever with no runner assigned — no records-ai PR can pass CI. Every other city-core repo (civicclerk, civiccore, ...) already uses GitHub-hostedubuntu-latest. This switches ci.yml/release-preflight.yml/release.yml toubuntu-latestto match. GitHub-hosted ubuntu supports the docker-compose backend job. This PR's own CI running (instead of hanging) is the proof.