fix(internal): use block size instead of key size for sym encryption - #698
Merged
Conversation
Contributor
|
Just a small nitpick thing, could you change "fix(internal)" in the commit to "internal/crypto"? |
For modes like CFB, OFB and CBC, python cryptography library expects IV size to be equal to the block size. AES uses a fixed block size of 128 bits (and so does Camellia from a quick search). This creates a size difference between key and block size when using any key size higher than 128 bits. While this might not cover expectations for all possible modes, changing the IV size from key length to block size should fix compability with 256 bits key size for the modes currently supported in the internal crypto library (currently mainly CFB due to `_symdef_to_crypt`). Signed-off-by: Julien Gomes <julien@arista.com>
Contributor
Author
|
Sure thing, changed the commit message prefix to "internal/crypto" |
whooo
approved these changes
Aug 5, 2026
Contributor
|
Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For modes like CFB, OFB and CBC, python cryptography library expects IV size to be equal to the block size.
AES uses a fixed block size of 128 bits (and so does Camellia from a quick search).
This creates a size difference between key and block size when using any key size higher than 128 bits.
While this might not cover expectations for all possible modes, changing the IV size from key length to block size should fix compability with 256 bits key size for the modes currently supported in the internal crypto library (currently mainly CFB due to
_symdef_to_crypt).