test: skip TraditionalOpenSSL PEM assertions in FIPS mode - #700
Open
stewartsmith wants to merge 1 commit into
Open
test: skip TraditionalOpenSSL PEM assertions in FIPS mode#700stewartsmith wants to merge 1 commit into
stewartsmith wants to merge 1 commit into
Conversation
When running in FIPS mode python-cryptography refuses to produce password-encrypted TraditionalOpenSSL (PKCS#1) PEM output: ValueError: Encrypted traditional OpenSSL format is not supported in FIPS mode Legacy PEM password encryption uses non-FIPS-approved KDFs not permitted in FIPS mode. Follow exising pattern of probing the optional crypto capability and calling self.skipTest() when the backend does not provide it. Signed-off-by: Stewart Smith <trawets@amazon.com>
whooo
reviewed
Aug 25, 2026
| try: | ||
| pem = priv.to_pem(pub.publicArea, password=b"foo") | ||
| except ValueError as e: | ||
| if "FIPS mode" in str(e): |
Contributor
There was a problem hiding this comment.
Could you use the full error string, so we don't accidentally match any other errors?
whooo
reviewed
Aug 25, 2026
| pem = priv.to_pem(pub.publicArea, password=b"foo") | ||
| except ValueError as e: | ||
| if "FIPS mode" in str(e): | ||
| self.skipTest(str(e)) |
Contributor
There was a problem hiding this comment.
A explicit reason why the test is skipped would be good, something like "not supported when OpenSSL is in FIPS mode" or similar
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running in FIPS mode python-cryptography refuses to produce password-encrypted TraditionalOpenSSL (PKCS#1) PEM output:
Legacy PEM password encryption uses non-FIPS-approved KDFs not permitted in FIPS mode.
Follow exising pattern of probing the optional crypto capability and calling self.skipTest() when the backend does not provide it.