Refactor 36#39
Merged
Merged
Conversation
- Parallel beams may intersect if they share an intersection of at least one point.
…ation. - No longer computing any determinants or the multiple cross products.
…r than "contains(..)".
- Integrated intersection constistency checking into intersects(..). - Cleaned up comments for documentation purposes.
…ort/long checks & lint primary files & delete PR tests
Combo of typo and typing fixes by @xbb - Fixed a bounding box check typo in check_skip_move - Fixed tgt_coords handling in check_skip_move, which previously passed a list to split_critical_beams where a single item is expected. Added a warning log (stderr) if more than one element is unexpectedly present. - Fixed some type annotations Note about the type annotations: - I'm not certain whether src_tgt_ids can ever be None, but since it's not handled in both check_critical_beams and the currently unused split_critical_beams, I removed None from latter's type annotations. - Further up the call chain None is still annotated for this argument, but I didn't change it there since I'm not sure what's the intended behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves upon #36 by:
Altogether, PR enables about 93s -> 40.7s runtime improvement in measured test (pyzx_random 5 qubit by 15 depth, seed:42, first_spider), with ballpark similar 2x speed improvements in other tests.