Pull request (merging) for reviewing - #5
Open
tr0llex wants to merge 157 commits into
Open
Conversation
…rite some models"
IlyaSaneev
reviewed
Jun 8, 2021
|
|
||
| class TokenManager { | ||
| private: | ||
| InMemoryDb tarantool; |
Collaborator
There was a problem hiding this comment.
Приватные переменные tarantool -> tarantool_
| int writeInMemory(const std::string& userName, const std::string& token, int status); | ||
| }; | ||
|
|
||
| class Auth : public AuthInterface { |
Collaborator
There was a problem hiding this comment.
class Auth, все поля класса должны быть либо приватными либо защищенными. Доступ к полям через сеттеры- геттеры
| int result = tokenMan.logoutUser(userName); | ||
| return result; | ||
| } | ||
| std::string loginUser (LoginData data) override { |
Collaborator
There was a problem hiding this comment.
data передается по значению
| int writeInMemory(const std::string& userName, const std::string& token, int status); | ||
| }; | ||
|
|
||
| class Auth : public AuthInterface { |
Collaborator
There was a problem hiding this comment.
Реализацию класса auth нужно вынести в cpp, а не hpp
| public: | ||
| User currentUser; | ||
| Auth() = default; | ||
| int logoutUser (std::string userName) override { |
Collaborator
There was a problem hiding this comment.
int logoutUser (std::string userName) override. Передача строки по значению.
| void logout(); | ||
|
|
||
| protected: | ||
| virtual void createMessengerLayout( |
Collaborator
There was a problem hiding this comment.
Почему отвечает за некое создание Layout’a мессенджера должен ответ унаследованный класс? Более в целом не ясно почему widget отвечает за создание Layout’a.
Или может выбрано неверное название метода?
| #include <cstdint> | ||
| #include <string> | ||
|
|
||
| class Compilation { |
Collaborator
There was a problem hiding this comment.
Структура с публичными полями
Comment on lines
+13
to
+16
| class ICompilationManager { | ||
| public: | ||
| virtual Compilation runCompilation(const Snippet &snippet, const string &executionStdin) = 0; | ||
| }; |
Comment on lines
+35
to
+43
| static void writeInputToFiles(const Compilation &compilation, const string &code, const string &input); | ||
|
|
||
| static void run(const Compilation &compilation); | ||
|
|
||
| static void removeOldDirs(); | ||
|
|
||
| void createDir(const Compilation &compilation); | ||
|
|
||
| static void readOutputFromFiles(Compilation &compilation); |
Collaborator
There was a problem hiding this comment.
Если методы static и private, то их можно убрать из hpp и полностью перенести в .cpp файл.
Comment on lines
+9
to
+23
| // using ::testing::Return; | ||
| // class MockDb : public IMainDb { | ||
| // public: | ||
| // MOCK_METHOD(User*, searchUserLogin, (std::string login, std::string password), (override)); | ||
| // MOCK_METHOD(void, writeUser, (User& user), (override)); | ||
| // MOCK_METHOD(int, updateUser, (User& user), (override)); | ||
| // MOCK_METHOD(std::string, getCodeFromMessage, (uint32_t messageId), (override)); | ||
| // MOCK_METHOD(void, writeMessageToDialogue, (Message message), (override)); | ||
| // MOCK_METHOD(std::vector <Message>*, getNMessagesFromDialogue, (uint32_t dialogueId, uint32_t senderId, | ||
| // uint32_t receiverId, long count), (override)); | ||
| // MOCK_METHOD(std::vector <Dialogue>*, getDialoguessByUserId, (int userId), (override)); | ||
| // MOCK_METHOD(uint32_t, createDialogue, (uint32_t senderId, uint32_t receiverId), (override)); | ||
| // MOCK_METHOD(void, deleteMessageFromDialogue, (Message& message), (override)); | ||
| // MOCK_METHOD(void, deleteDialogue, (Dialogue& dialogue), (override)); | ||
| // }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.