Conversation
Retain query-preserving redirects and keep registry, catalogs, handlers, font subset and route tests aligned. Ultraworked with [omo](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: sisyphus-dev-ai <sisyphus-dev-ai@users.noreply.github.com>
There was a problem hiding this comment.
1 issue found across 36 files
Confidence score: 4/5
tests/e2e/generators-utils-ui.spec.jsbypasses the user-facing redirect by using an API request for/token-counterand loading/prompt-template-builderdirectly, so redirect regressions could go undetected; update the test to exercise the browser navigation path.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="tests/e2e/generators-utils-ui.spec.js">
<violation number="1" location="tests/e2e/generators-utils-ui.spec.js:150">
P3: This test never exercises the user-facing redirect: it fetches /token-counter through the API request context and separately loads /prompt-template-builder directly, so the browser path that actually sends users to the builder is untested. Navigate through the redirect in the browser (page.goto('/token-counter') then assert final URL) and, like the sibling /pipe test in page-sweep-2026-05-11.spec.js, assert the landing page renders the prompt builder rather than just matching its URL.</violation>
</file>
Shadow auto-approve: would not auto-approve because issues were found.
Re-trigger cubic
| page, | ||
| request, | ||
| }) => { | ||
| const redirect = await request.get("/token-counter", { maxRedirects: 0 }); |
There was a problem hiding this comment.
P3: This test never exercises the user-facing redirect: it fetches /token-counter through the API request context and separately loads /prompt-template-builder directly, so the browser path that actually sends users to the builder is untested. Navigate through the redirect in the browser (page.goto('/token-counter') then assert final URL) and, like the sibling /pipe test in page-sweep-2026-05-11.spec.js, assert the landing page renders the prompt builder rather than just matching its URL.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At tests/e2e/generators-utils-ui.spec.js, line 150:
<comment>This test never exercises the user-facing redirect: it fetches /token-counter through the API request context and separately loads /prompt-template-builder directly, so the browser path that actually sends users to the builder is untested. Navigate through the redirect in the browser (page.goto('/token-counter') then assert final URL) and, like the sibling /pipe test in page-sweep-2026-05-11.spec.js, assert the landing page renders the prompt builder rather than just matching its URL.</comment>
<file context>
@@ -143,22 +143,21 @@ test.describe("Generator and utility tools UI interactions", () => {
+ page,
+ request,
+ }) => {
+ const redirect = await request.get("/token-counter", { maxRedirects: 0 });
+ expect(redirect.status()).toBe(301);
+ expect(new URL(redirect.headers().location).pathname).toBe(
</file context>
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
refactor(routes): retire token counter and pipe. This is logical change 2/11 in the dependency-ordered product-audit release stack.
Refs #969
What changed
5aa335cca3e2ecb40cf450d8cc9a46ed04ef8b68; validated tree:70ea8cffb37fb493ba30ccff8085c24c85993278.Why
Remove the retired token counter and pipe routes without leaving broken registry entries, fonts, or bookmarks.
Verification
bun run buildpassed on this exact candidate tree.npm test -- --maxWorkers=2passed on this exact candidate tree.Four retired URL/slash/query fixtures returned the correct 301 targets; no retired cards or sitemap entries; 45 public tools and 3 dev games.
Final combined tree additionally passed 801 unit tests and all 293 Playwright tests with retries disabled, plus all 48 primary tool workflows at desktop and mobile. The exploratory Color Converter exact-HEX boundary remains a documented pre-existing defect; its runtime is unchanged by this stack.
Risk & rollback
Summary by cubic
Retires the token counter and pipe routes (Refs #969).
/token-counterand/pipenow 301 to/prompt-template-builderand/json-formatterinstead of rendering their pages, so existing bookmarks and query strings keep working; the production catalog drops from 47 to 45 tools.Refactors
Rollout
Written for commit 5aa335c. Summary will update on new commits.