Skip to content

test(generators): restore diagram and SVG workflows - #976

Open
trac3r00 wants to merge 1 commit into
release/product-value-20260912-06from
release/product-value-20260912-07
Open

trac3r00 wants to merge 1 commit into
release/product-value-20260912-06from
release/product-value-20260912-07

Conversation

@trac3r00

@trac3r00 trac3r00 commented Sep 12, 2026

Copy link
Copy Markdown
Owner

Summary

test(generators): restore diagram and SVG workflows. This is logical change 7/11 in the dependency-ordered product-audit release stack.

Refs #969

What changed

  • test(generators): restore diagram and SVG workflows
  • Exact source commit: 02161b8e63c18609ddd8ec7110e0fedc500df032; validated tree: a6911d347c46476884356c33cd8a9db55477d9c1.
  • Depends on the preceding release-stack PR. Retarget to main only after its dependency is merged and deployed.

Why

Restore two quarantined browser workflows and reject stale output as false passing evidence.

Verification

  • bun run build passed on this exact candidate tree.
  • npm test -- --maxWorkers=2 passed on this exact candidate tree.
  • Affected behavior manually exercised as described below.
  • Latest GitHub Build, Unit Tests (Vitest), and E2E Tests (Playwright) must all pass before merge.
Tests  766 passed (766)
CANDIDATE_BUILD_UNIT_GREEN
Committed tree equals validated tree: a6911d347c46476884356c33cd8a9db55477d9c1

Both Mermaid and SVG browser workflows passed with unique changed-input markers.

Final combined tree additionally passed 801 unit tests and all 293 Playwright tests with retries disabled, plus all 48 primary tool workflows at desktop and mobile. The exploratory Color Converter exact-HEX boundary remains a documented pre-existing defect; its runtime is unchanged by this stack.

Risk & rollback

  • Risk: Dependent commits require earlier stack changes; merge in order.
  • Rollback: revert this PR through a new PR; do not revert dependencies beneath already-merged dependents.
  • Release: require an approving review and latest-SHA CI. Respect the 15-minute soak between deploy-affecting merges and verify the production deployment before continuing.

Summary by cubic

Restores the quarantined diagram and SVG browser workflows (Refs #969). The tests now run again and require fresh output matching changed input, so stale SVG no longer passes as valid.

Merge only after the preceding release-stack PR is merged and deployed.

Written for commit 02161b8. Summary will update on new commits.

Review in cubic

Re-enable both quarantined browser flows and require fresh output matching changed input rather than accepting stale SVG.

Ultraworked with [omo](https://github.com/code-yeongyu/oh-my-openagent)

Co-authored-by: sisyphus-dev-ai <sisyphus-dev-ai@users.noreply.github.com>

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Shadow auto-approve: would auto-approve. Re-enables two quarantined browser e2e tests for Mermaid and SVG tools, making them wait for unique input markers and verifying output. Test-only change; no production behavior altered.

Re-trigger cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant