-
Notifications
You must be signed in to change notification settings - Fork 127
Upgrade to wgpu v28 #1119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Upgrade to wgpu v28 #1119
Conversation
ArthurBrussee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love to see it! Just drive-by reviewing
|
@ArthurBrussee I kept the current behavior fixed to 1 device, but lmk if supporting more than one adapter might still make sense. Everything else has been updated, will run some tests. |
|
|
||
| # TODO: remove once sysinfo release includes windows 0.62 (required for wgpu) | ||
| [patch.crates-io] | ||
| sysinfo = { git = "https://github.com/GuillaumeGomez/sysinfo", rev = "b0ae22bfb2064d74e9561fb71890ad68763c7aff" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't merge until all our dependencies are on crates.io, otherwise it blocks any release we want to do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know.. this might be blocked until then. Had to apply this patch otherwise it wouldn't compile on windows targets due to conflicting windows types (see this build output).
wgpu requires windows 0.62 (used for DX12), and sysinfo uses the win APIs as well so it pulls windows but the latest release currently requires >=0.59, <0.62.
enumerate_adapters(now async and avail on WebGPU)wgpu::PollType::Wait(now a struct w/ submission index and timeout fields)subgroup_{min,max}_size(renamed + now inAdapterInfonot limits)sysinfo(used in cubecl-cpu, required for burn) to be compatible withwindowscrate version for wgpu (otherwise we get compilation errors in burn)It is important that you make sure that you don't introduce any bugs in burn.
Instructions