Skip to content

Conversation

@laggui
Copy link
Member

@laggui laggui commented Dec 22, 2025

It is important that you make sure that you don't introduce any bugs in burn.

Instructions

  • Create a new branch or fork of the burn repo
  • Update the main Cargo.toml with this PR hash.
  • Fix any broken tests or compilation errors in burn.
  •  Submit a PR in burn with your fixes and link it here.

@laggui laggui mentioned this pull request Dec 22, 2025
4 tasks
Copy link
Contributor

@ArthurBrussee ArthurBrussee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love to see it! Just drive-by reviewing

@laggui
Copy link
Member Author

laggui commented Dec 22, 2025

@ArthurBrussee I kept the current behavior fixed to 1 device, but lmk if supporting more than one adapter might still make sense.

Everything else has been updated, will run some tests.


# TODO: remove once sysinfo release includes windows 0.62 (required for wgpu)
[patch.crates-io]
sysinfo = { git = "https://github.com/GuillaumeGomez/sysinfo", rev = "b0ae22bfb2064d74e9561fb71890ad68763c7aff" }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't merge until all our dependencies are on crates.io, otherwise it blocks any release we want to do.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know.. this might be blocked until then. Had to apply this patch otherwise it wouldn't compile on windows targets due to conflicting windows types (see this build output).

wgpu requires windows 0.62 (used for DX12), and sysinfo uses the win APIs as well so it pulls windows but the latest release currently requires >=0.59, <0.62.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants