Add inverse trigonometric and hyperbolic trait impls for Line<P> #1125
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ArcSin,ArcCos,ArcTan,ArcSinh,ArcCosh,ArcTanhtrait implementations forLine<P>Tan,Sinh,Coshimplementations for completenessMotivation
The
Line<P>type was missing trait implementations for inverse trigonometric and hyperbolic functions, even though:unary.rsArithmetic::ArcSin, etc.)This change simply exposes the existing functionality to
Line<P>, following the same pattern used forSin,Cos, andTanh.Changes
File:
crates/cubecl-core/src/frontend/container/line/ops.rsPTest plan
test_asin,test_acos,test_atan,test_asinh,test_acosh,test_atanhwith vectorization levels 2 and 4)cargo check -p cubecl-corepassescargo test -p cubecl-wgpu -- unarypasses (27 tests)🤖 Generated with Claude Code