Skip to content

#fix error code 400 to 409 for a conflict #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Baptiste-Ferrand merged 2 commits into from
Aug 11, 2025
Merged

#fix error code 400 to 409 for a conflict #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3f17c0
fix error code 400 to 409 for a conflict
Baptiste-Ferrand Aug 11, 2025
eb2cb2f
update the test 👌
Baptiste-Ferrand Aug 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/entrypoints/api/routers/profile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ async def create_profile(
legacy=dto.legacy,
)
except DuplicateProfileError as e:
raise HTTPException(status_code=400, detail=str(e))
raise HTTPException(status_code=409, detail=str(e))
except InvalidConfirmPasswordError as e:
raise HTTPException(status_code=400, detail=str(e))
except InvalidFormatEmailError as e:
Expand Down
4 changes: 2 additions & 2 deletions src/entrypoints/api/tests/profile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,15 +78,15 @@ async def test_06_user_cannot_update_roles(self, client):
)
assert r.status_code == 403

async def test_07_create_duplicate_user_profile_returns_400(self, client):
async def test_07_create_duplicate_user_profile_returns_409(self, client):
payload = {
"email": "alice@example.com",
"password": "Secret123!",
"confirm_password": "Secret123!",
"name": "Alice Dup"
}
r = await client.post("/profiles", json=payload)
assert r.status_code == 400
assert r.status_code == 409
assert "already exists" in r.json()["detail"].lower()

async def test_08_coach_cannot_update_user_profile(self, client):
Expand Down