Skip to content

Shift redundant code to #includes files#13

Merged
mhpob merged 2 commits into
mainfrom
includes
May 21, 2026
Merged

Shift redundant code to #includes files#13
mhpob merged 2 commits into
mainfrom
includes

Conversation

@mhpob

@mhpob mhpob commented May 19, 2026

Copy link
Copy Markdown
Collaborator

This PR tries to move code redundant across programs into files that can be sourced by those programs. There were a few tradeoffs as there wasn't a "one size fits all" solution.

  • Time-varying detection intercepts are of a different structure (time x receiver matrix) than the constant, "standard" versions (one number). I created a different likelihood for each.
  • The tag-integrated model has an extra likelihood and extra data. I just kept these in the "master" model.
  • Logistic decay has a slightly different likelihood Gaussian. I added a "logistic = 0" switch to go between them.

@mhpob mhpob assigned mhpob and unassigned mhpob May 19, 2026
@mhpob mhpob requested a review from benjaminhlina May 19, 2026 20:27

@benjaminhlina benjaminhlina left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great and really like how this removes redundancy in the code. I think the few areas where #inspect couldn't be used make sense given the specifics of what the model is doing.

@mhpob mhpob merged commit 35557fb into main May 21, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants