Update the golang examples to use the migrated starknet.go module#79
Open
noahhh3 wants to merge 3 commits into
Open
Update the golang examples to use the migrated starknet.go module#79noahhh3 wants to merge 3 commits into
noahhh3 wants to merge 3 commits into
Conversation
|
Thanks. The current go sample is not workable. Pls check and merge this PR. |
halink0803
suggested changes
Mar 11, 2025
amayvs
approved these changes
Apr 22, 2025
amayvs
requested changes
Apr 22, 2025
amayvs
left a comment
amayvs
left a comment
Contributor
There was a problem hiding this comment.
@noahhh3 Could you fix following benchmark
=== RUN BenchmarkGnarkSignSingleOrder
BenchmarkGnarkSignSingleOrder
/Users/amay/Code/paradigm/forked/code-samples/go/signable_starknet_test.go:93:
Error Trace: /Users/amay/Code/paradigm/forked/code-samples/go/signable_starknet_test.go:93
Error: Should be true
Test: BenchmarkGnarkSignSingleOrder
Messages: signature is invalid: wrong size buffer
--- FAIL: BenchmarkGnarkSignSingleOrder
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update existing golang examples to v0.7.2 of github.com/NethermindEth/starknet.go since github.com/dontpanicdao/caigo was migrated to it.