fix(ingest): say when a file is dropped for the 1 MB cap (#370) - #399
Frankie-Xu wants to merge 1 commit into
Conversation
🌱 graft blast radius5 areas changed → 7 areas can be affected. 33 dependent symbols, depth 2. flowchart TB
A0(("Workspace Graph<br/>15 symbols"))
A1(("Review Process<br/>8 symbols"))
A2(("Tool Invocation<br/>3 symbols"))
A3(("Context Management<br/>3 symbols"))
A4(("Graph Engine<br/>2 symbols"))
AX(("2 smaller areas<br/>2 symbols"))
classDef reached fill:#D9EDF3,stroke:#3AA7C9,stroke-width:1.5px,color:#0E313C;
class A0,A1,A2,A3,A4 reached;
classDef tail fill:#EEF2F3,stroke:#9AA4A9,stroke-width:1px,color:#3A4247;
class AX tail;
Who knows this code — 5 people across 12 areas
Ownership is git history over each area's own files, weighted towards recent work (120-day half-life). Merge commits and bots are dropped, and you are dropped from your own PR. A name with no All 33 dependent symbols, grouped by areaWorkspace Graph — 15 symbols in 6 files
Review Process — 8 symbols in 6 files
Tool Invocation — 3 symbols in 1 file
Context Management — 3 symbols in 2 files
Graph Engine — 2 symbols in 1 file
build-viewer.mjs — 1 symbol in 1 file
Sync Execution — 1 symbol in 1 file
Test signal per changed area — 4 ✓ · 1 ✗Reached = a node under a test path has a resolved edge into the changed symbol. It undercounts anything called indirectly — through a CLI, a spawned process or a dynamic import — so read a low ratio as “look here”, never as a coverage gate.
33 test suites also reference this code43 symbols, kept out of the diagram and the table so they cannot crowd out the areas a reviewer has to look at.
Open the interactive graph → — click an area to see the code that changed, and the line that reaches it. |
Summary
graft buildthen reportedparsed: 1 of 1 files, andask/grep/skeletontold the agent the symbol or file did not exist.⚠ skipped <path>: N MB > 1 MB capandparsed: … (N skipped: size). The skipped set is stored onwiring.jsonmeta.skippedso later queries can name it.Not in this PR
--max-file-bytes.Closes #370
Test plan
ok.tsindexed,big.tsat 1 MB + 1 byte recorded inskippedbuildGraphresult andskeleton big.tsname the skip instead of "no definitions indexed"ask/grepnotes includeskipped big.ts: … > 1 MB capnode --import tsx --test --test-name-pattern "#370" test/ingest-fs.test.ts test/search-grep.test.ts test/ask.test.ts