64-bit compatibility #67
Conversation
|
|
ekilmer
left a comment
ekilmer
left a comment
There was a problem hiding this comment.
Thank you for your contribution and testing for 64-bit compatibility!
I've left a few comments to begin with, and I hope we can make this modular enough to build both 32-bit and 64-bit versions.
CMakeLists.txt
Outdated
| #-m32 | ||
| ) | ||
|
|
||
| # Link everything 32-bit (until we have a 64-bit option) | ||
| set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -m32") | ||
| set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} -m32") | ||
| set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} ")#-m32") | ||
| set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} ") #-m32") |
There was a problem hiding this comment.
Could you please add an option to compile 32 bit or 64 bit
There was a problem hiding this comment.
If it's as easy as making this flag optional, yes!
However, I might also have added compiler flags that 32-bit compilers or let's say older compiler versions, do not handle. Need to look in to it, but will do 👍
| #if which ninja 2>&1 >/dev/null; then | ||
| # CMAKE_OPTS="-G Ninja $CMAKE_OPTS" | ||
| # BUILD_FLAGS= | ||
| #else | ||
| # BUILD_FLAGS="-- -j$(getconf _NPROCESSORS_ONLN)" | ||
| BUILD_FLAGS= | ||
| fi | ||
| #fi |
There was a problem hiding this comment.
We prefer to use Ninja, when it's available, but adding an option to force Makefiles seems like a good idea.
Could you add an option for overriding Ninja here?
There was a problem hiding this comment.
Exactly, ninja is fast, but not everyone uses them. Makefiles are just more widely adapted and a good tool to build challenges individually. I'll make it an option 👍
| set( SERVICE_ID "00075" ) | ||
| set( AUTHOR_ID "KPRCA" ) | ||
| add_compile_options( -O3 -g -DDISABLE_HEAP_GUARD ) | ||
| add_compile_options( -O3 -g -DDISABLE_HEAP_GUARDi -fpermissive -fms-extensions ) |
There was a problem hiding this comment.
I think there's an extraneous i character at the end of -DDISABLE_HEAP_GUARDi
| set( SERVICE_ID "00119" ) | ||
| set( AUTHOR_ID "KPRCA" ) | ||
| add_compile_options( -Oz -g ) | ||
| add_compile_options( -Os -g ) |
There was a problem hiding this comment.
I'm curious, why does this need changed?
There was a problem hiding this comment.
Apparantly, -Oz is a MacOS version of -Os ¯_(ツ)_/¯
|
@dns43 I just realized now that the CLA hasn't been signed. Could you please sign that? It must be signed before merging this PR. |
|
done |
3 participants
This repo builds under GCC v7.4.0 (e.g. also AFL v2.25b) and CLANG 7.0.0 in 64bit.