-
Notifications
You must be signed in to change notification settings - Fork 15
Upgrade to LLVM 13, 14, 15 + CI improvements #18
base: master
Are you sure you want to change the base?
Conversation
… -fix-errors --fix main.cpp`
…rtifact, add a macos runner
Add support for LLVM 13.0.0 Update CMakeLists.txt Update CMakeList to enable LLVM 13 Fix a missing parenthesis Fix a missing parenthesis which causes the build failure.
|
On mac with clang 15 from homebrew (arm64 M1 mac) I get a weird error. See it on GHA here: https://github.com/jmarrec/constexpr-everything/actions/runs/4020220358/jobs/6907896141#step:4:15 On Ubuntu 20.04 too, clang 15, see it failing on GHA here: https://github.com/jmarrec/constexpr-everything/actions/runs/4020206830/jobs/6907869443#step:5:6 This seems to fix it... diff --git a/CMakeLists.txt b/CMakeLists.txt
index 11911ec..8b9e0c6 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -65,11 +65,4 @@ target_link_libraries(${PROJECT_NAME} ${LIBRARY_LIST})
target_link_libraries(
${PROJECT_NAME}
- LLVMTransformUtils
- LLVMAnalysis
- LLVMTarget
- LLVMOption # Support
- LLVMObject # BitReader, Core, Support
- LLVMBitReader # Core, Support
- LLVMCore # Support
- LLVMSupport)
+ LLVM)This actually reduces the binary size... 4 to 6 MB less cf before: https://github.com/jmarrec/constexpr-everything/actions/runs/4020059164 |
|
Thanks a ton for tackling this! I should have some time to do a full review this afternoon. |
| LLVMBitReader # Core, Support | ||
| LLVMCore # Support | ||
| LLVMSupport) | ||
| LLVM) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for trimming this -- IIRC we had to specify all of these manually for a much earlier version of LLVM.
woodruffw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks a ton again! Once you sign the CLA I should be able to merge this in and get a release made.
I saw #17 only after I was done, so I tried to integrate @clin99 's changes into my branch.