Open
Conversation
adding attribution to files I added
|
|
Contributor
|
@Katastropic2431 @G0ne-Phishing: thank you both for these PRs that look amazing ❤️ Do you think you could sign the Contributor Licence Agreement (CLA)? It's required for me to be able to merge PRs. In the meantime I'll approve the CI run to see if the tests pass. I need to find some time to manually review your PRs as they are all quite massive, but skimming through this one it looks like this is high-quality work! Kudos for sharing your contributions with the community! I'm curious regarding the context of this work and whether it's a scolarship project or addresses internal needs at DSTG Cyber. Feel free to reach out through my email (in my Github profile) or share yours so we can chat further :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DSTG student development for integrating Armv7 support.