Skip to content

Add support for month param - #163

Merged
edalzell merged 4 commits into
mainfrom
feature/support-for-modifier-params
Jun 4, 2026
Merged

Add support for month param#163
edalzell merged 4 commits into
mainfrom
feature/support-for-modifier-params

Conversation

@marcorieser

@marcorieser marcorieser commented May 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

This PR

  • uses the current year for the comparison (same as before, but simpler in code. we never cared about the year)
  • adds support for passing the month as a parameter to the modifier (fallback to get query param)
  • adds tests for the InMonth modifier

@marcorieser marcorieser self-assigned this May 29, 2026
@edalzell
edalzell marked this pull request as draft May 29, 2026 16:42
@marcorieser
marcorieser marked this pull request as ready for review May 29, 2026 19:21
@marcorieser
marcorieser requested a review from edalzell May 29, 2026 19:21
@marcorieser

marcorieser commented May 29, 2026

Copy link
Copy Markdown
Member Author

@edalzell ready for review

@edalzell
edalzell merged commit 1a8e8eb into main Jun 4, 2026
24 checks passed
@edalzell
edalzell deleted the feature/support-for-modifier-params branch June 4, 2026 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@edalzell edalzell edalzell approved these changes

Assignees

@marcorieser marcorieser

Labels

feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@marcorieser @edalzell