fix(mac): release remote drag during touch teardown - #46
Open
franekmat wants to merge 1 commit into
Open
Conversation
|
@franekmat is attempting to deploy a commit to the tranvuongquocdat2-7001's projects Team on Vercel. A member of the Team first needs to authorize it. |
franekmat
marked this pull request as ready for review
July 24, 2026 02:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Centralize remote gesture cleanup and run it when:
If SideScreen previously posted a synthetic
leftMouseDownfor a long-press drag, cleanup now posts the matchingleftMouseUp. It also cancels pending long-press and momentum-scroll work before returning the gesture state to idle.Why
The long-press drag path posts
leftMouseDownwhen movement begins. Some interruption paths previously discarded the.draggingstate without postingleftMouseUp.One reproducible case is placing a second finger while dragging: Android sends a two-pointer down event, and the Mac host immediately replaced
.draggingwith the two-finger state. The active application could then continue behaving as though the left mouse button was held.The same imbalance was possible if touch was disabled, the client disconnected, or the server stopped during a drag.
Validation
swift test— 35 tests passed