fix: Flamegraph - Bars aren't configurable in the settings#65
Merged
Conversation
Add flame_bar_height and flame_bar_gap settings to ViewState, exposed in a new Flamegraph tab in the Settings dialog. Values are persisted to the settings JSON file and used by the flamegraph icicle renderer instead of the previous hardcoded constants. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
flame_bar_heightandflame_bar_gapsettings toViewState, replacing the hardcodedBAR_H = 20.0fandBAR_GAP = 1.0fconstants in the flamegraph rendererCloses #60
🤖 Generated with Claude Code