Repository navigation
test(tools): match the air-gapped OSV refusal message (development CI) - #235
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
developmentCI is red:test (3.11)andtest (3.12)each fail one test,tests/v1/context/test_tool_reports.py::test_osv_without_a_live_osv_source_is_refused.Cause: two PRs that were each green crossed when both merged.
"no OSV lookup".context/tools.pyto"no OSV API lookup: the feeds registry has no live osv source, or it is air-gapped". It updated its own test intest_tools.pyto the new wording, but feat(context): tool report doors for traust's adapters CLI (XWING-2440) #225's test didn't exist yet.Fix: the test now matches
"no OSV API lookup", the same wordingtest_tools.pyalready asserts. Nothing changes in behaviour or source.Changed tests:
test_tool_reports.py::test_osv_without_a_live_osv_source_is_refused: the regex is"no OSV lookup"→"no OSV API lookup". It follows feat(exposure): air-gapped advisory reads from exported OSV records #233's deliberate message change; the case and the exception type are unchanged.Local checks on
development+ this commit:make lint: clean.make test: 6871 passed, 1 skipped.development: clean.