Repository navigation
test(ops): record keeps a refused answer's reason; loop-over-the-pack coverage from traust (XWING-2440) - #112
Merged
1 commit merged intoOct 27, 2026
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smith-xyz The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Merged
9 of 11 tasks
4039118
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plan:
plans/traust-standardization/0-continuous-ops/in-review/17-shaun-traust-core-only.md(part)Wave 2 lane (f) of the traust-core-only chain. traust's engine-loop tests over the security pack (
tests/test_shadow_run.py,tests/test_security_router_engine.py) leave traust in the traust lane (f) PR; the decision (2026-10-26) is that loop-over-the-pack tests live here with the pack as a fixture, and the engine stays free of security-pack concepts.What
This repo already runs the loop over a minimal, sanitized pack fixture (
tests/fixtures/packs/security-source.yaml, shaped like traust'spacks/security/assets.yaml, no estate data). Each loop behaviour the traust tests exercised maps onto an existing test here; the one that had no counterpart is added:test_a_repo_state_completion_routes_the_repository_oncerepo_stateroutes once; re-routes are idempotenttest_engine_loop.py::test_a_materialized_source_unblocks_downstream_and_routes_once,::test_routing_the_same_repository_again_plans_no_second_ordertest_an_iac_change_routes_the_cloud_config_lane_beside_the_tablestest_engine_loop.py::test_every_route_with_a_lane_plans_its_lane_asset_oncetest_a_threat_model_pr_stamp_reaches_the_diff_scans_sessiontest_ops_runner.py::test_a_routed_order_gets_the_rule_that_routed_it(rule-3+threat-model-pr),::test_a_skill_session_with_a_command_runs_with_its_roletest_a_secret_in_the_patch_escalates_…test_engine_loop.py::test_every_route_with_a_lane_plans_its_lane_asset_oncetest_a_lane_over_its_budget_is_withheldtest_engine_loop.py::test_the_lane_budget_cuts_the_lowest_priority_routed_worktest_a_forge_host_past_its_quota_is_deferredtest_engine_loop.py::test_quota_is_per_forge_host,::test_quota_refills_and_admits_the_deferred_ordertest_a_minor_release_routes_a_rating_review_…test_engine_loop.py::test_a_recorded_release_routes_each_repository_it_ships_oncetest_a_traust_door_is_recorded_as_it_answeredrecordkeeps a refused answer and its reason on the ordertest_ops_shadow.py::test_record_a_refused_answer_leaves_the_order_refused_with_its_reasontest_shadow_routes_a_recorded_repo_state_with_the_security_routershadow --routerroutes a recordedrepo_state, plans nothingtest_ops_shadow.py::test_shadow_routes_with_the_pack_router,::test_shadow_prints_what_a_pass_would_plan_and_diff_compares_itWhat the security router decides (rule 5, lever 6, tripwire, threat-model PR stamp, release re-model) stays tested in traust (
tests/test_security_router.py), without the engine.Behaviour: none changed; tests only.
Tests
make lint-fix && make test: 1285 passed, 26 skipped.Changed tests
None (one test added).
Chain: traust-core #222, #223, #225, #229 → traust #291 (lane f; stacked on traust #279, #283, #284, #285, #286) · traust-engine #112.