Skip to content

feat(ops): pass the claiming worker to session commands - #131

Merged
JGiola merged 2 commits into
developmentfrom
feat/session-contract-and-runner
Oct 30, 2026
Merged

JGiola merged 2 commits into
developmentfrom
feat/session-contract-and-runner

Conversation

@JGiola

@JGiola JGiola commented Oct 30, 2026 •

Copy link
Copy Markdown

Plan: plans/traust-standardization/13-artifact-only-sessions/done/01-jacopo-session-contract-and-runner.md

Summary

Forward the claim runner's existing worker identity to artifact-only session commands.

  • Supply {worker} from the same self._worker used for claim, heartbeat and completion.
  • Keep whole-token argv substitution and the existing execution lifecycle.
  • Pin core to merged commit acf67b8a4409ed7afa1b79d7954636b5b169fa64 on development from feat(ops): record artifact-only sessions under the runner lease traust-core#309, which supplies session audit recording and portable manifest/heartbeat serialization.
  • Document the placeholder and prove the actual command receives both the claimed order and its worker.

Verification

  • make lint-fix and make test: 146 passed, no skips, against the pinned core commit.
  • Consumer drift ratchet: passed.
  • Independent read-only review of the handoff: no findings.

Parity

Behavior Result
Claim identity The existing claiming worker supplies the new token
Heartbeats and completion Existing identity and lifecycle retained
Command construction Whole-token argv substitution retained; no shell string
Session evidence admission The session can pass the actual holder to core rather than infer it from a stored row

Reviewer checks

  • {worker} is the claiming runner's identity.
  • Claim, heartbeat and completion retain their existing engine flow.
  • The dependency pin includes the approved session contracts and core recording behavior.
  • Existing refused-result round-trip remains covered with a registered reason.

Quality checklist

  • 1. Comments only for the non-trivial
  • 2. Short docstrings
  • 3. Existing owners reused
  • 4. No duplicated worker identity
  • 5. Actual command handoff covered
  • 6. Real core services exercised by runner tests
  • 7. Minimal source change
  • 8. No query changes
  • 9. Existing fixture value change explicitly approved

Changed tests

Test Old → new Why / approval
tests/test_ops_shadow.py::test_outcome Refused-answer fixture and matching expected value: unregistered "x" → OrderReason.NOT_FOUND The updated core pin enforces registered reasons; the refusal equality assertion is unchanged. Jacopo explicitly approved this fixture change on 2026-10-30.
  • A person reviewed each changed test and the behavior change is intended.

Delivery

Core #309 is merged; this PR pins its merge commit on development. The harness PR consumes this placeholder in below_range_review. Human review required; auto-merge is disabled and this PR must not be merged automatically.

@JGiola
JGiola requested a review from a team as a code owner October 30, 2026 15:36
@JGiola
JGiola requested a review from smith-xyz October 30, 2026 15:36
@openshift-ci

openshift-ci Bot commented Oct 30, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JGiola

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2026
@JGiola
JGiola merged commit 7db9a3c into development Oct 30, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant