Repository navigation
ci: GitHub Actions for lint, test, integration, security, drift, e2e and guardrails - #42
Merged
Merged
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smith-xyz The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
GitHub Actions for the SDK, shaped like traust-core's, with a tighter merge gate. Today the repo has no CI; only local hooks, which
--no-verifyskips.ci.yml(PR, merge queue, push tomain/development)lintmake linttestgo test -race ./...(the runner's heartbeat / lease loss is concurrent)integrationmake test-integrationon PostgreSQL 16securitymake security(pinned govulncheck, gosec)driftmake -C go check-drift: generated code matchesCONTRACTS_REF/CORE_REF, never hand-editede2emake e2e:traust-serverfrom core atCORE_REF(SQLite, local issuer), generated client checks auth, paging, typed 404 / 401 problemsguardrailsmake guardrails: no committed spec, no package outside AGENTS.md's list, no env reads /database/sql/ hand-built URLs in framework packages, estate data, conventional commitscore-head.yml(nightly)developmenttip; red = bumpCORE_REFauto-merge.ymltype(scope)!:PR is armed only by theautomergelabelreview-after-merge.ymlreview/after-mergeCODEOWNERS: the framework's shape only (AGENTS.md,.agents/,.github/,ci/,go/go.mod,go/Makefile,go/internal/generate/,go/v1/api/client.go,go/v1/ops/,go/v1/feed/) → @smith-xyz @chubirka. Drops the*catch-all so routine PRs don't wait on a reviewer..github/pull_request_template.mdfrom AGENTS.md's rules.ci/lang/_base.yml,ci/lang/go.yml(no.gitlab-ci.ymlruns them);ci/lang/go/ci.pystays (security tool pins).Stacked
On #39 (
CORE_REFlives in its Makefile). Review the last commit.Repo settings (admin, after merge)
auto-merge.ymlandreview-after-merge.ymlusepull_request_target, which only fires from the default branch (main), so they need a sync tomain. Then:development: required checkslint,test,integration,security,drift,e2e,guardrails; required approvals 0 with code-owner review on (CODEOWNERS paths still need an owner); signed commits stay.Changed tests
None.
Checks
make lint,make guardrails,make -C go check-drift,make e2e(4 e2e tests pass locally against core1a6779a)go test -race ./...