Skip to content

ci: retire auto-merge workflow - #51

Merged
smith-xyz merged 1 commit into
traust-security:developmentfrom
smith-xyz:chore/disable-automerge
Oct 30, 2026
Merged

smith-xyz merged 1 commit into
traust-security:developmentfrom
smith-xyz:chore/disable-automerge

Conversation

@smith-xyz

Copy link
Copy Markdown
Contributor

What

  • Deletes .github/workflows/auto-merge.yml — the pull_request_target workflow that armed GitHub's native auto-merge (the automerge label or a ticked test checkbox) so green PRs landed without a click
  • Drops the now-dead doc references

Why

Active development is cooling off and Qodo now handles code review, so the unattended-merge path is no longer worth a standing privileged trigger with a write token. Required checks still gate every merge — merging just needs a click again.

Notes

  • PRs already armed keep GitHub's native auto-merge setting; disable via the PR UI if one should not land unattended
  • The repo-level "Allow auto-merge" setting can be turned off separately once this merges

Active development is cooling off and Qodo covers review, so the
unattended-merge path is no longer worth a standing pull_request_target
workflow with a write token. Required checks still gate every merge -
they now just need a click.
@smith-xyz
smith-xyz requested a review from chubirka as a code owner October 30, 2026 18:40
@openshift-ci

openshift-ci Bot commented Oct 30, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smith-xyz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2026
@qodo-for-traust-security

Copy link
Copy Markdown

PR Summary by Qodo

Retire the auto-merge workflow

⚙️ Configuration changes 📝 Documentation 🕐 Less than 10 minutes


AI Description

• Remove the privileged workflow that automatically armed eligible PRs for merging.
• Keep required CI checks; merging now requires a manual action.
• Remove the obsolete workflow reference from the contributor guide.
Diagram

graph TD
  PR["Pull Request"] --> CI["CI workflow"] --> Gate{"Checks pass?"} -->|yes| Merge["Manual merge"] --> Labeler["Review labeler"]
  Gate -->|no| Block["Merge blocked"]
Loading
High-Level Assessment

Deleting the workflow directly removes the standing privileged trigger. Disabling repository-level auto-merge alone would not remove that workflow; the setting can be turned off separately. PRs already armed for native auto-merge must be disabled individually if they should not merge unattended.

Files changed (1) +1 / -1

Documentation (1) +1 / -1
CONTRIBUTING.mdRemove obsolete auto-merge workflow reference +1/-1

Remove obsolete auto-merge workflow reference

• The CI pipeline guidance no longer describes the deleted auto-merge workflow as part of the merge-by-risk flow. It continues to document the nightly core check, post-merge review workflow, and CODEOWNERS approval.

CONTRIBUTING.md

@qodo-for-traust-security

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Powered by Qodo

@smith-xyz
smith-xyz merged commit 56e98d5 into traust-security:development Oct 30, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant