Skip to content

fix(validation): leave unjudged worklist validity unanswered - #295

Merged
smith-xyz merged 1 commit into
developmentfrom
fix/unjudged-worklist-validity-qjd5zssc
Oct 28, 2026
Merged

smith-xyz merged 1 commit into
developmentfrom
fix/unjudged-worklist-validity-qjd5zssc

Conversation

@chubirka

Copy link
Copy Markdown
Member

Classifier plan 05 — unjudged worklist validity

Target development, not main. Required reviewer @smith-xyz; retain the merge hold and no auto-merge.

Existing-contract repair

Cluster drift and validation-benchmark outputs are unjudged worklists, not canonical validity decisions or full modern audit reports. Omit the deprecated validation_status: not_verified label rather than inventing confirmation/refutation or an evidence grade.

  • Remove the obsolete field from cluster_state_diff candidates.
  • Adopt Engine #115, exact candidate 5bd3ae9b8604d72852e20014b648c388552a6159, which does the same for benchmark claims. The existing direct Core override is unchanged.
  • Add a source-output behavior regression and patch metadata 0.39.1; no tag/release created.

Verification

  • Both new output regressions failed before and passed after (Engine and App).
  • App lint/format and full PostgreSQL-enabled suite: 2652 passed, 2 skipped. Remaining skips are the bare operational-config template and missing universal-ctags.
  • Actual installed CLI sweep benchmark ... plan and python -m traust.cli.cluster_state_diff diff ... generated four benchmark claims and one drift candidate without validity labels. No cluster operation or canonical state write was performed.
  • The actual validation JSON parser normalized all claim fields identically to copies containing the legacy label. The frozen installed Engine commit was checked; no source-path override was used for CLI acceptance.
  • Docs/license and 0.39.1 metadata checks passed. Existing tests were not re-pinned.

Scope / rollout

Merge Engine #115 first, then this adoption. This is independent of the pending finding-kind batch (Core #242/App #293); preserve both sets of pins/release metadata when reconciling parallel merges.

The finite closeout checklist separately records remaining audit-report no-answer/revision validator alignment, triage-kind representation and SDK legacy-wire owner gaps. Removing an unused worklist label does not activate a new report gate, retire historical source schemas, rewrite reports, or declare the whole validity family/plan05 closed. No vocabulary, schema, OWASP-methodology, table/column or Core decision-policy change.

@openshift-ci

openshift-ci Bot commented Oct 27, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chubirka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2026
@chubirka
chubirka requested a review from smith-xyz October 27, 2026 21:18
@chubirka chubirka added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 27, 2026
@smith-xyz
smith-xyz force-pushed the fix/unjudged-worklist-validity-qjd5zssc branch from 609a5a4 to 2bde499 Compare October 28, 2026 13:58
@smith-xyz
smith-xyz merged commit 71c3f34 into development Oct 28, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants