Repository navigation
build: depend on plain traust-core now that the grammars ship with it - #323
Merged
Merged
Conversation
traust-core makes the tree-sitter grammars regular dependencies, so the [js,java,rust,ruby] extras go. `traust admin doctor` checks each grammar loads and names the coverage gap when one won't. The observe test stubs core's forge API, since GitHub reads no longer go through gh. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chubirka The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
traust-core#293 makes the tree-sitter grammars regular core dependencies. The
[js,java,rust,ruby]extras no longer exist, so every install has the Express, Java, Rust and Ruby route matrices.What
traust-core[js,java,rust,ruby]becomestraust-core. The core pin moves to4c698cdb(the head of fix(classifiers): cut over authored finding-kind output #293; core merges with merge commits, so the SHA survives the merge).traust admin doctorgets acheck_grammarsrow per language. A grammar that won't import is a WARN that uses core'sgrammar_missingwording and says the framework's routes are a coverage gap.secure-code-auditSKILL.md andframework-checks.mdname the grammar packages and the doctor check instead of the extras.gh), sotest_portfolio_observe.pynow stubs core's forge API. Without that, the test would call api.github.com.Verification
make test: 2,641 passed, 69 skipped. The estate-data, alignment and skill-security gates are green.traust admin doctor --quickfrom this tree prints✓ JS/TS / Java / Rust / Ruby grammar loads.uv.lockkeeps revision 3.Changed tests
Approved by the reviewer before the change.
test_framework_checks.py::test_web_sections_name_their_deterministic_evidence"traust-core[js]" in text→"tree-sitter-javascript" in texttest_framework_checks.py::test_jvm_rust_and_ruby_sections_name_their_matrix_markerstraust-core[{java,rust,ruby}]→tree-sitter-{java,rust,ruby}test_portfolio_observe.py(fixture +test_a_never_audited_repository_succeeds_without_the_forge)ProcessRunner.run(gh) → stubs core'sForgeApi.get, with responses in GitHub REST shape; assertions unchangedMerge after traust-core#293.
🤖 Generated with Claude Code