Repository navigation
merge queue: checking #241 on main (2f494d2), stacked on #240 - #243
Closed
mergify[bot] wants to merge 3 commits into
Closed
mergify[bot] wants to merge 3 commits into
mergify[bot] wants to merge 3 commits into
Conversation
Bumps the misc-minor-patch group with 6 updates: | Package | From | To | | --- | --- | --- | | [org.jetbrains.kotlin:kotlin-metadata-jvm](https://github.com/JetBrains/kotlin) | `2.4.20` | `2.4.21` | | [gradle-wrapper](https://github.com/gradle/gradle) | `9.8.0` | `9.8.1` | | [org.jetbrains.kotlin:kotlin-test](https://github.com/JetBrains/kotlin) | `2.4.20` | `2.4.21` | | [org.jetbrains.kotlin.multiplatform](https://github.com/JetBrains/kotlin) | `2.4.20` | `2.4.21` | | [org.jetbrains.kotlin.plugin.compose](https://github.com/JetBrains/kotlin) | `2.4.20` | `2.4.21` | | [org.jetbrains.kotlin.plugin.serialization](https://github.com/JetBrains/kotlin) | `2.4.20` | `2.4.21` | Updates `org.jetbrains.kotlin:kotlin-metadata-jvm` from 2.4.20 to 2.4.21 - [Release notes](https://github.com/JetBrains/kotlin/releases) - [Changelog](https://github.com/JetBrains/kotlin/blob/master/ChangeLog.md) - [Commits](JetBrains/kotlin@v2.4.20...v2.4.21) Updates `gradle-wrapper` from 9.8.0 to 9.8.1 - [Release notes](https://github.com/gradle/gradle/releases) - [Commits](gradle/gradle@v9.8.0...v9.8.1) Updates `org.jetbrains.kotlin:kotlin-test` from 2.4.20 to 2.4.21 - [Release notes](https://github.com/JetBrains/kotlin/releases) - [Changelog](https://github.com/JetBrains/kotlin/blob/master/ChangeLog.md) - [Commits](JetBrains/kotlin@v2.4.20...v2.4.21) Updates `org.jetbrains.kotlin.multiplatform` from 2.4.20 to 2.4.21 - [Release notes](https://github.com/JetBrains/kotlin/releases) - [Changelog](https://github.com/JetBrains/kotlin/blob/master/ChangeLog.md) - [Commits](JetBrains/kotlin@v2.4.20...v2.4.21) Updates `org.jetbrains.kotlin.plugin.compose` from 2.4.20 to 2.4.21 - [Release notes](https://github.com/JetBrains/kotlin/releases) - [Changelog](https://github.com/JetBrains/kotlin/blob/master/ChangeLog.md) - [Commits](JetBrains/kotlin@v2.4.20...v2.4.21) Updates `org.jetbrains.kotlin.plugin.serialization` from 2.4.20 to 2.4.21 - [Release notes](https://github.com/JetBrains/kotlin/releases) - [Changelog](https://github.com/JetBrains/kotlin/blob/master/ChangeLog.md) - [Commits](JetBrains/kotlin@v2.4.20...v2.4.21) Updates `org.jetbrains.kotlin.multiplatform` from 2.4.20 to 2.4.21 - [Release notes](https://github.com/JetBrains/kotlin/releases) - [Changelog](https://github.com/JetBrains/kotlin/blob/master/ChangeLog.md) - [Commits](JetBrains/kotlin@v2.4.20...v2.4.21) Updates `org.jetbrains.kotlin.plugin.compose` from 2.4.20 to 2.4.21 - [Release notes](https://github.com/JetBrains/kotlin/releases) - [Changelog](https://github.com/JetBrains/kotlin/blob/master/ChangeLog.md) - [Commits](JetBrains/kotlin@v2.4.20...v2.4.21) Updates `org.jetbrains.kotlin.plugin.serialization` from 2.4.20 to 2.4.21 - [Release notes](https://github.com/JetBrains/kotlin/releases) - [Changelog](https://github.com/JetBrains/kotlin/blob/master/ChangeLog.md) - [Commits](JetBrains/kotlin@v2.4.20...v2.4.21) --- updated-dependencies: - dependency-name: org.jetbrains.kotlin:kotlin-metadata-jvm dependency-version: 2.4.21 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: misc-minor-patch - dependency-name: gradle-wrapper dependency-version: 9.8.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: misc-minor-patch - dependency-name: org.jetbrains.kotlin:kotlin-test dependency-version: 2.4.21 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: misc-minor-patch - dependency-name: org.jetbrains.kotlin.multiplatform dependency-version: 2.4.21 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: misc-minor-patch - dependency-name: org.jetbrains.kotlin.plugin.compose dependency-version: 2.4.21 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: misc-minor-patch - dependency-name: org.jetbrains.kotlin.plugin.serialization dependency-version: 2.4.21 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: misc-minor-patch - dependency-name: org.jetbrains.kotlin.multiplatform dependency-version: 2.4.21 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: misc-minor-patch - dependency-name: org.jetbrains.kotlin.plugin.compose dependency-version: 2.4.21 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: misc-minor-patch - dependency-name: org.jetbrains.kotlin.plugin.serialization dependency-version: 2.4.21 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: misc-minor-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis merge-queue draft validates #241 on top of the queued #240 changes; its implementation updates pinned GitHub Actions commits and performs a coordinated Kotlin 2.4.21, kotlin-metadata-jvm, and Gradle 9.8.1 toolchain refresh. Review the action SHA provenance and confirm all platform builds and CI integrations remain compatible with the upgraded toolchain. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
✅
|
| Descriptor | Linter | Files | Fixed | Errors | Max errors | Warnings | Elapsed time |
|---|---|---|---|---|---|---|---|
| detekt | yes | 194 | no | 3.88s | |||
| ✅ KOTLIN | ktlint | 1 | 0 | 0 | 0 | 1.4s |
Detailed Issues
⚠️ KOTLIN / detekt - 194 errors
shared/src/commonMain/kotlin/com/autka/feature/external/MarketplaceSearchLinks.kt:206:17: The function autoScout24 appears to be too complex based on Cyclomatic Complexity (complexity: 16). Defined complexity threshold for methods is set to '15' [CyclomaticComplexMethod]
shared/src/commonMain/kotlin/com/autka/feature/external/MarketplaceSearchLinks.kt:36:8: Object 'MarketplaceSearchLinks' with '28' functions detected. Defined threshold inside objects is set to '11' [TooManyFunctions]
shared/src/commonMain/kotlin/com/autka/core/model/ImportCostEstimate.kt:56:17: The function estimate(vehiclePriceUsd: Double, shippingUsd: Double, engineCapacityCc: Int?, fuelType: FuelType, customsDutyRate: Double, vatRate: Double) has too many parameters. The current threshold is set to 6. [LongParameterList]
app/src/test/java/com/autka/feature/importcalc/ImportCalculatorInputTest.kt:102:25: The function evaluate(vehiclePrice: String, shipping: String, customs: String, vat: String, engine: String, fuel: FuelType) has too many parameters. The current threshold is set to 6. [LongParameterList]
app/src/test/java/com/autka/feature/listings/ListingsFilteringTest.kt:30:22: The function offer(id: String, price: Double, currency: Currency, region: Region, fuel: FuelType, year: Int?, mileageKm: Int?, make: String, model: String, postedAtEpochMs: Long?) has too many parameters. The current threshold is set to 6. [LongParameterList]
app/src/test/java/com/autka/screenshots/ScreenshotTest.kt:191:26: The function offer(n: Int, title: String, make: String, model: String, price: Money, region: Region, location: String, fuel: FuelType) has too many parameters. The current threshold is set to 6. [LongParameterList]
app/src/main/java/com/autka/feature/map/MapScreen.kt:46:5: The function MapScreen is too long (113). The maximum length is 60. [LongMethod]
app/src/main/java/com/autka/feature/map/MapScreen.kt:46:5: The function MapScreen appears to be too complex based on Cyclomatic Complexity (complexity: 15). Defined complexity threshold for methods is set to '15' [CyclomaticComplexMethod]
app/src/main/java/com/autka/feature/importcalc/ImportCalculatorInput.kt:41:14: The function evaluateImportCalculatorInput appears to be too complex based on Cyclomatic Complexity (complexity: 22). Defined complexity threshold for methods is set to '15' [CyclomaticComplexMethod]
app/src/main/java/com/autka/feature/importcalc/ImportCalculatorInput.kt:71:9: This condition is too complex (5). Defined complexity threshold for conditions is set to '4' [ComplexCondition]
app/src/main/java/com/autka/feature/importcalc/ImportCalculatorScreen.kt:124:27: The function ImportCalculatorScreen(onBack: () -> Unit, displayCurrency: Currency, exchangeRates: ExchangeRates?, presets: List<ImportAssumptionPreset>, onSavePreset: (String, Double, Double, Double) -> Unit, onDeletePreset: (String) -> Unit) has too many parameters. The current threshold is set to 6. [LongParameterList]
app/src/main/java/com/autka/feature/importcalc/ImportCalculatorScreen.kt:375:28: The function AssumptionsCard(expanded: Boolean, assumptionsAreDefault: Boolean, canCollapse: Boolean, shippingText: String, customsRateText: String, vatRateText: String, shippingInvalid: Boolean, customsRateInvalid: Boolean, vatRateInvalid: Boolean, defaultShippingText: String, defaultCustomsPercentText: String, defaultVatPercentText: String, presets: List<ImportAssumptionPreset>, canSavePreset: Boolean, onExpandedChange: (Boolean) -> Unit, onShippingChange: (String) -> Unit, onCustomsRateChange: (String) -> Unit, onVatRateChange: (String) -> Unit, onApplyPreset: (ImportAssumptionPreset) -> Unit, onSavePreset: (String) -> Unit, onDeletePreset: (String) -> Unit, onReset: () -> Unit) has too many parameters. The current threshold is set to 6. [LongParameterList]
app/src/main/java/com/autka/feature/importcalc/ImportCalculatorScreen.kt:375:13: The function AssumptionsCard is too long (129). The maximum length is 60. [LongMethod]
app/src/main/java/com/autka/feature/importcalc/ImportCalculatorScreen.kt:124:5: The function ImportCalculatorScreen is too long (233). The maximum length is 60. [LongMethod]
app/src/main/java/com/autka/feature/importcalc/ImportCalculatorScreen.kt:124:5: The function ImportCalculatorScreen appears to be too complex based on Cyclomatic Complexity (complexity: 22). Defined complexity threshold for methods is set to '15' [CyclomaticComplexMethod]
app/src/main/java/com/autka/feature/importcalc/ImportPresetControls.kt:24:14: The function ImportPresetControls is too long (62). The maximum length is 60. [LongMethod]
app/src/main/java/com/autka/feature/vin/VinDecoderScreen.kt:56:5: The function VinDecoderScreen is too long (82). The maximum length is 60. [LongMethod]
app/src/main/java/com/autka/feature/vin/VinDecoderScreen.kt:150:13: The function VinResultCard appears to be too complex based on Cyclomatic Complexity (complexity: 18). Defined complexity threshold for methods is set to '15' [CyclomaticComplexMethod]
app/src/main/java/com/autka/feature/detail/OfferDetailScreen.kt:176:28: The function ImportBreakdown(est: ImportCostEstimate, displayCurrency: Currency, rates: ExchangeRates?, shippingUsd: Double, engineCapacityCc: Int?, engineCapacityRequired: Boolean, onShippingChange: (Double?) -> Unit, onEngineCapacityChange: (Int?) -> Unit) has too many parameters. The current threshold is set to 6. [LongParameterList]
app/src/main/java/com/autka/feature/detail/OfferDetailScreen.kt:81:5: The function OfferDetailScreen is too long (79). The maximum length is 60. [LongMethod]
app/src/main/java/com/autka/feature/detail/OfferDetailScreen.kt:176:13: The function ImportBreakdown is too long (89). The maximum length is 60. [LongMethod]
app/src/main/java/com/autka/feature/detail/OfferDetailScreen.kt:176:13: The function ImportBreakdown appears to be too complex based on Cyclomatic Complexity (complexity: 15). Defined complexity threshold for methods is set to '15' [CyclomaticComplexMethod]
app/src/main/java/com/autka/feature/listings/FilterSheet.kt:55:16: The function FilterSheet(filter: SearchFilter, availableMakes: List<String>, availableSources: List<SourceInfo>, priceCurrency: Currency, onApply: (SearchFilter) -> Unit, onReset: () -> Unit, onDismiss: () -> Unit) has too many parameters. The current threshold is set to 6. [LongParameterList]
app/src/main/java/com/autka/feature/listings/FilterSheet.kt:55:5: The function FilterSheet is too long (222). The maximum length is 60. [LongMethod]
app/src/main/java/com/autka/feature/listings/FilterSheet.kt:55:5: The function FilterSheet appears to be too complex based on Cyclomatic Complexity (complexity: 29). Defined complexity threshold for methods is set to '15' [CyclomaticComplexMethod]
app/src/main/java/com/autka/feature/listings/ListingsFiltering.kt:17:20: The function applyFilter appears to be too complex based on Cyclomatic Complexity (complexity: 28). Defined complexity threshold for methods is set to '15' [CyclomaticComplexMethod]
app/src/main/java/com/autka/feature/listings/SavedSearchesRow.kt:39:21: The function SavedSearchesRow(filter: SearchFilter, displayCurrency: Currency, savedSearches: List<SavedSearch>, canSave: Boolean, onSave: (String, SearchFilter, Currency) -> Unit, onApply: (SavedSearch) -> Unit, onDelete: (String) -> Unit) has too many parameters. The current threshold is set to 6. [LongParameterList]
app/src/main/java/com/autka/feature/listings/SavedSearchesRow.kt:39:5: The function SavedSearchesRow is too long (91). The maximum length is 60. [LongMethod]
app/src/main/java/com/autka/feature/listings/ListingsScreen.kt:77:18: The function ListingsRoute(onOfferClick: (String) -> Unit, onMapClick: () -> Unit, onImportCalculatorClick: () -> Unit, onVinDecoderClick: () -> Unit, onSourceHealthClick: () -> Unit, viewModel: ListingsViewModel) has too many parameters. The current threshold is set to 6. [LongParameterList]
app/src/main/java/com/autka/feature/listings/ListingsScreen.kt:106:19: The function ListingsScreen(uiState: ListingsUiState, onQueryChange: (String) -> Unit, onSearch: () -> Unit, onApplyFilter: (SearchFilter) -> Unit, onApplySavedSearch: (SavedSearch) -> Unit, onResetFilter: () -> Unit, onSaveSearch: (String, SearchFilter, Currency) -> Unit, onDeleteSavedSearch: (String) -> Unit, onDisplayCurrencyChange: (Currency) -> Unit, onOfferClick: (String) -> Unit, onMapClick: () -> Unit, onImportCalculatorClick: () -> Unit, onVinDecoderClick: () -> Unit, onSourceHealthClick: () -> Unit) has too many parameters. The current threshold is set to 6. [LongParameterList]
app/src/main/java/com/autka/feature/listings/ListingsScreen.kt:106:5: The function ListingsScreen is too long (176). The maximum length is 60. [LongMethod]
app/src/main/java/com/autka/feature/listings/ListingsScreen.kt:106:5: The function ListingsScreen appears to be too complex based on Cyclomatic Complexity (complexity: 16). Defined complexity threshold for methods is set to '15' [CyclomaticComplexMethod]
app/src/main/java/com/autka/feature/sourcehealth/SourceHealthScreen.kt:58:5: The function SourceHealthScreen is too long (79). The maximum length is 60. [LongMethod]
app/src/main/java/com/autka/ui/components/LocalizedNumberParsing.kt:6:14: The function parseLocalizedNonNegativeAmount appears to be too complex based on Cyclomatic Complexity (complexity: 29). Defined complexity threshold for methods is set to '15' [CyclomaticComplexMethod]
app/src/main/java/com/autka/data/remote/backend/BackendApi.kt:12:23: The function offers(query: String?, make: String?, model: String?, minPrice: Double?, maxPrice: Double?, minYear: Int?, maxYear: Int?, maxMileageKm: Int?, fuelTypes: String?, transmissions: String?, regions: String?, sources: String?, sort: String?, complete: Boolean?, limit: Int?, offset: Int?) has too many parameters. The current threshold is set to 6. [LongParameterList]
app/src/main/java/com/autka/data/settings/SettingsRepository.kt:51:7: Class 'DataStoreSettingsRepository' with '13' functions detected. Defined threshold inside classes is set to '11' [TooManyFunctions]
app/src/main/java/com/autka/data/settings/SettingsRepository.kt:129:13: This condition is too complex (7). Defined complexity threshold for conditions is set to '4' [ComplexCondition]
app/src/main/java/com/autka/data/settings/SettingsRepository.kt:268:13: This condition is too complex (8). Defined complexity threshold for conditions is set to '4' [ComplexCondition]
app/src/main/java/com/autka/feature/external/MarketplaceLinksRow.kt:113:14: The caught exception is swallowed. The original exception could be lost. [SwallowedException]
app/src/main/java/com/autka/feature/external/ImportServicesSection.kt:45:18: The caught exception is swallowed. The original exception could be lost. [SwallowedException]
app/src/main/java/com/autka/feature/listings/ListingsViewModel.kt:137:22: The caught exception is too generic. Prefer catching specific exceptions to the case that is currently handled. [TooGenericExceptionCaught]
app/src/main/java/com/autka/data/repository/DefaultExchangeRateRepository.kt:63:17: Do not rethrow a caught exception of the same type. [RethrowCaughtException]
app/src/main/java/com/autka/feature/map/MapScreen.kt:46:5: Function names should match the pattern: [a-z][a-zA-Z0-9]* [FunctionNaming]
app/src/main/java/com/autka/feature/map/MapRoute.kt:10:5: Function names should match the pattern: [a-z][a-zA-Z0-9]* [FunctionNaming]
app/src/main/java/com/autka/feature/external/MarketplaceLinksRow.kt:41:5: Function names should match the pattern: [a-z][a-zA-Z0-9]* [FunctionNaming]
app/src/main/java/com/autka/feature/external/ImportServicesSection.kt:33:5: Function names should match the pattern: [a-z][a-zA-Z0-9]* [FunctionNaming]
app/src/main/java/com/autka/feature/importcalc/ImportCalculatorScreen.kt:107:5: Function names should match the pattern: [a-z][a-zA-Z0-9]* [FunctionNaming]
app/src/main/java/com/autka/feature/importcalc/ImportCalculatorScreen.kt:124:5: Function names should match the pattern: [a-z][a-zA-Z0-9]* [FunctionNaming]
app/src/main/java/com/autka/feature/importcalc/ImportCalculatorScreen.kt:375:13: Function names should match the pattern: [a-z][a-zA-Z0-9]* [FunctionNaming]
app/src/main/java/com/autka/feature/importcalc/ImportCalculatorScreen.kt:544:13: Function names should match the pattern: [a-z][a-zA-Z0-9]* [FunctionNaming]
app/src/main/java/com/autka/feature/importcalc/ImportCalculatorScreen.kt:606:13: Function names should match the pattern: [a-z][a-zA-Z0-9]* [FunctionNaming]
app/src/main/java/com/autka/feature/importcalc/ImportPresetControls.kt:24:14: Function names should match the pattern: [a-z][a-zA-Z0-9]* [FunctionNaming]
app/src/main/java/com/autka/feature/vin/VinDecoderScreen.kt:41:5: Function names should match the pattern: [a-z][a-zA-Z0-9]* [FunctionNaming]
app/src/main/java/com/autka/feature/vin/VinDecoderScreen.kt:56:5: Function names should match the pattern: [a-z][a-zA-Z0-9]* [FunctionNaming]
app/src/main/java/com/autka/feature/vin/VinDecoderScreen.kt:150:13: Function names should match the pattern: [a-z][a-zA-Z0-9]* [FunctionNaming]
app/src/main/java/com/autka/feature/vin/VinDecoderScreen.kt:207:13: Function names should match the pattern: [a-z][a-zA-Z0-9]* [FunctionNaming]
app/src/main/java/com/autka/feature/detail/OfferDetailScreen.kt:66:5: Function names should match the pattern: [a-z][a-zA-Z0-9]* [FunctionNaming]
app/src/main/java/com/autka/feature/detail/OfferDetailScreen.kt:81:5: Function names should match the pattern: [a-z][a-zA-Z0-9]* [FunctionNaming]
app/src/main/java/com/autka/feature/detail/OfferDetailScreen.kt:168:13: Function names should match the pattern: [a-z][a-zA-Z0-9]* [FunctionNaming]
app/src/main/java/com/autka/feature/detail/OfferDetailScreen.kt:176:13: Function names should match the pattern: [a-z][a-zA-Z0-9]* [FunctionNaming]
app/src/main/java/com/autka/feature/detail/OfferDetailScreen.kt:282:13: Function names should match the pattern: [a-z][a-zA-Z0-9]* [FunctionNaming]
app/src/main/java/com/autka/feature/listings/FilterSheet.kt:55:5: Function names should match the pattern: [a-z][a-zA-Z0-9]* [FunctionNaming]
app/src/main/java/com/autka/feature/listings/FilterSheet.kt:299:13: Function names should match the pattern: [a-z][a-zA-Z0-9]* [FunctionNaming]
app/src/main/java/com/autka/feature/listings/SavedSearchesRow.kt:39:5: Function names should match the pattern: [a-z][a-zA-Z0-9]* [FunctionNaming]
app/src/main/java/com/autka/feature/listings/ListingsScreen.kt:77:5: Function names should match the pattern: [a-z][a-zA-Z0-9]* [FunctionNaming]
app/src/main/java/com/autka/feature/listings/ListingsScreen.kt:106:5: Function names should match the pattern: [a-z][a-zA-Z0-9]* [FunctionNaming]
app/src/main/java/com/autka/feature/listings/ListingsScreen.kt:308:13: Function names should match the pattern: [a-z][a-zA-Z0-9]* [FunctionNaming]
app/src/main/java/com/autka/feature/listings/ListingsScreen.kt:330:13: Function names should match the pattern: [a-z][a-zA-Z0-9]* [FunctionNaming]
app/src/main/java/com/autka/feature/listings/ListingsScreen.kt:369:13: Function names should match the pattern: [a-z][a-zA-Z0-9]* [FunctionNaming]
app/src/main/java/com/autka/feature/listings/ListingsScreen.kt:385:13: Function names should match the pattern: [a-z][a-zA-Z0-9]* [FunctionNaming]
app/src/main/java/com/autka/feature/listings/ListingsScreen.kt:437:13: Function names should match the pattern: [a-z][a-zA-Z0-9]* [FunctionNaming]
app/src/main/java/com/autka/feature/sourcehealth/SourceHealthScreen.kt:44:5: Function names should match the pattern: [a-z][a-zA-Z0-9]* [FunctionNaming]
app/src/main/java/com/autka/feature/sourcehealth/SourceHealthScreen.kt:58:5: Function names should match the pattern: [a-z][a-zA-Z0-9]* [FunctionNaming]
app/src/main/java/com/autka/feature/sourcehealth/SourceHealthScreen.kt:144:13: Function names should match the pattern: [a-z][a-zA-Z0-9]* [FunctionNaming]
app/src/main/java/com/autka/ui/AutkaApp.kt:29:5: Function names should match the pattern: [a-z][a-zA-Z0-9]* [FunctionNaming]
app/src/main/java/com/autka/ui/components/OfferImage.kt:21:5: Function names should match the pattern: [a-z][a-zA-Z0-9]* [FunctionNaming]
app/src/main/java/com/autka/ui/components/OfferImage.kt:38:13: Function names should match the pattern: [a-z][a-zA-Z0-9]* [FunctionNaming]
app/src/main/java/com/autka/ui/components/CommonComponents.kt:21:5: Function names should match the pattern: [a-z][a-zA-Z0-9]* [FunctionNaming]
app/src/main/java/com/autka/ui/components/CommonComponents.kt:28:5: Function names should match the pattern: [a-z][a-zA-Z0-9]* [FunctionNaming]
app/src/main/java/com/autka/ui/components/CommonComponents.kt:38:5: Function names should match the pattern: [a-z][a-zA-Z0-9]* [FunctionNaming]
app/src/main/java/com/autka/ui/theme/Theme.kt:60:5: Function names should match the pattern: [a-z][a-zA-Z0-9]* [FunctionNaming]
app/src/main/java/com/autka/core/util/Result.kt:4:18: The file name 'Result' does not match the name of the single top-level declaration 'FetchResult'. [MatchingDeclarationName]
shared/src/commonMain/kotlin/com/autka/feature/external/MarketplaceSearchLinks.kt:347:17: Function copart has 3 return statements which exceeds the limit of 2. [ReturnCount]
shared/src/commonMain/kotlin/com/autka/feature/external/MarketplaceSearchLinks.kt:445:2: The file shared/src/commonMain/kotlin/com/autka/feature/external/MarketplaceSearchLinks.kt is not ending with a new line. [NewLineAtEndOfFile]
shared/src/commonMain/kotlin/com/autka/feature/external/MarketplaceSearchLinks.kt:141:1: Line detected, which is longer than the defined maximum line length in the code style. [MaxLineLength]
shared/src/commonMain/kotlin/com/autka/feature/external/MarketplaceSearchLinks.kt:213:1: Line detected, which is longer than the defined maximum line length in the code style. [MaxLineLength]
shared/src/commonMain/kotlin/com/autka/feature/external/MarketplaceSearchLinks.kt:275:1: Line detected, which is longer than the defined maximum line length in the code style. [MaxLineLength]
shared/src/commonMain/kotlin/com/autka/feature/external/MarketplaceSearchLinks.kt:320:1: Line detected, which is longer than the defined maximum line length in the code style. [MaxLineLength]
shared/src/commonMain/kotlin/com/autka/feature/external/MarketplaceSearchLinks.kt:365:17: iaai is returning a constant. Prefer declaring a constant instead. [FunctionOnlyReturningConstant]
shared/src/commonMain/kotlin/com/autka/feature/external/MarketplaceSearchLinks.kt:293:72: This expression contains a magic number. Consider defining it to a well named constant. [MagicNumber]
shared/src/commonMain/kotlin/com/autka/feature/external/MarketplaceSearchLinks.kt:403:54: This expression contains a magic number. Consider defining it to a well named constant. [MagicNumber]
shared/src/commonMain/kotlin/com/autka/feature/external/MarketplaceSearchLinks.kt:431:38: This expression contains a magic number. Consider defining it to a well named constant. [MagicNumber]
shared/src/commonMain/kotlin/com/autka/feature/external/MarketplaceSearchLinks.kt:440:35: This expression contains a magic number. Consider defining it to a well named constant. [MagicNumber]
shared/src/commonMain/kotlin/com/autka/core/model/ExchangeRates.kt:19:9: Function convert has 4 return statements which exceeds the limit of 2. [ReturnCount]
shared/src/commonMain/kotlin/com/autka/core/model/ImportCostEstimate.kt:38:9: Function exciseRate has 3 return statements which exceeds the limit of 2. [ReturnCount]
shared/src/commonMain/kotlin/com/autka/core/model/ImportCostEstimate.kt:43:23: This expression contains a magic number. Consider defining it to a well named constant. [MagicNumber]
shared/src/commonMain/kotlin/com/autka/core/model/ImportCostEstimate.kt:44:23: This expression contains a magic number. Consider defining it to a well named constant. [MagicNumber]
shared/src/commonMain/kotlin/com/autka/core/model/ImportCostEstimate.kt:44:31: This expression contains a magic number. Consider defining it to a well named constant. [MagicNumber]
shared/src/commonMain/kotlin/com/autka/core/model/ImportCostEstimate.kt:48:23: This expression contains a magic number. Consider defining it to a well named constant. [MagicNumber]
shared/src/commonMain/kotlin/com/autka/core/model/ImportCostEstimate.kt:48:31: This expression contains a magic number. Consider defining it to a well named constant. [MagicNumber]
shared/src/commonMain/kotlin/com/autka/core/model/ImportCostEstimate.kt:49:23: This expression contains a magic number. Consider defining it to a well named constant. [MagicNumber]
shared/src/commonMain/kotlin/com/autka/core/model/ImportCostEstimate.kt:49:31: This expression contains a magic number. Consider defining it to a well named constant. [MagicNumber]
shared/src/commonMain/kotlin/com/autka/core/model/ImportCostEstimate.kt:52:31: This expression contains a magic number. Consider defining it to a well named constant. [MagicNumber]
shared/src/commonMain/kotlin/com/autka/core/model/ImportCostEstimate.kt:52:37: This expression contains a magic number. Consider defining it to a well named constant. [MagicNumber]
app/src/test/java/com/autka/screenshots/ScreenshotTest.kt:222:1: Line detected, which is longer than the defined maximum line length in the code style. [MaxLineLength]
app/src/test/java/com/autka/screenshots/ScreenshotTest.kt:223:1: Line detected, which is longer than the defined maximum line length in the code style. [MaxLineLength]
app/src/test/java/com/autka/screenshots/ScreenshotTest.kt:224:1: Line detected, which is longer than the defined maximum line length in the code style. [MaxLineLength]
app/src/main/java/com/autka/feature/external/MarketplaceWebSearch.kt:93:17: Function sanitizeSearchTerm has 4 return statements which exceeds the limit of 2. [ReturnCount]
app/src/main/java/com/autka/feature/external/MarketplaceWebSearch.kt:80:9: The loop contains more than one break or continue statement. The code should be refactored to increase readability. [LoopWithTooManyJumpStatements]
app/src/main/java/com/autka/feature/external/MarketplaceWebSearch.kt:81:34: This expression contains a magic number. Consider defining it to a well named constant. [MagicNumber]
app/src/main/java/com/autka/feature/external/MarketplaceWebSearch.kt:82:31: This expression contains a magic number. Consider defining it to a well named constant. [MagicNumber]
app/src/main/java/com/autka/feature/external/MarketplaceWebSearch.kt:83:78: This expression contains a magic number. Consider defining it to a well named constant. [MagicNumber]
app/src/main/java/com/autka/feature/external/MarketplaceWebSearch.kt:87:30: This expression contains a magic number. Consider defining it to a well named constant. [MagicNumber]
app/src/main/java/com/autka/feature/external/ImportServicesSection.kt:61:1: Line detected, which is longer than the defined maximum line length in the code style. [MaxLineLength]
app/src/main/java/com/autka/feature/importcalc/ImportCalculatorViewModel.kt:42:50: This expression contains a magic number. Consider defining it to a well named constant. [MagicNumber]
app/src/main/java/com/autka/feature/importcalc/ImportCalculatorInput.kt:49:51: This expression contains a magic number. Consider defining it to a well named constant. [MagicNumber]
app/src/main/java/com/autka/feature/importcalc/ImportCalculatorInput.kt:50:39: This expression contains a magic number. Consider defining it to a well named constant. [MagicNumber]
app/src/main/java/com/autka/feature/importcalc/ImportCalculatorInput.kt:63:87: This expression contains a magic number. Consider defining it to a well named constant. [MagicNumber]
app/src/main/java/com/autka/feature/importcalc/ImportCalculatorInput.kt:64:74: This expression contains a magic number. Consider defining it to a well named constant. [MagicNumber]
app/src/main/java/com/autka/feature/importcalc/ImportCalculatorScreen.kt:97:35: This expression contains a magic number. Consider defining it to a well named constant. [MagicNumber]
app/src/main/java/com/autka/feature/importcalc/ImportCalculatorScreen.kt:98:34: This expression contains a magic number. Consider defining it to a well named constant. [MagicNumber]
app/src/main/java/com/autka/feature/importcalc/ImportCalculatorScreen.kt:99:27: This expression contains a magic number. Consider defining it to a well named constant. [MagicNumber]
app/src/main/java/com/autka/feature/importcalc/ImportCalculatorScreen.kt:100:29: This expression contains a magic number. Consider defining it to a well named constant. [MagicNumber]
app/src/main/java/com/autka/feature/detail/OfferDetailViewModel.kt:87:58: This expression contains a magic number. Consider defining it to a well named constant. [MagicNumber]
app/src/main/java/com/autka/feature/detail/OfferDetailScreen.kt:101:1: Line detected, which is longer than the defined maximum line length in the code style. [MaxLineLength]
app/src/main/java/com/autka/feature/detail/OfferDetailScreen.kt:128:1: Line detected, which is longer than the defined maximum line length in the code style. [MaxLineLength]
app/src/main/java/com/autka/feature/detail/OfferDetailScreen.kt:200:1: Line detected, which is longer than the defined maximum line length in the code style. [MaxLineLength]
app/src/main/java/com/autka/feature/listings/FilterSheet.kt:150:59: This expression contains a magic number. Consider defining it to a well named constant. [MagicNumber]
app/src/main/java/com/autka/feature/listings/ListingsViewModel.kt:78:54: This expression contains a magic number. Consider defining it to a well named constant. [MagicNumber]
app/src/main/java/com/autka/feature/listings/ListingsScreen.kt:399:1: Line detected, which is longer than the defined maximum line length in the code style. [MaxLineLength]
app/src/main/java/com/autka/feature/listings/ListingsScreen.kt:400:1: Line detected, which is longer than the defined maximum line length in the code style. [MaxLineLength]
app/src/main/java/com/autka/feature/listings/ListingsScreen.kt:409:1: Line detected, which is longer than the defined maximum line length in the code style. [MaxLineLength]
app/src/main/java/com/autka/feature/listings/ListingsScreen.kt:410:1: Line detected, which is longer than the defined maximum line length in the code style. [MaxLineLength]
app/src/main/java/com/autka/feature/sourcehealth/SourceHealthScreen.kt:188:1: Line detected, which is longer than the defined maximum line length in the code style. [MaxLineLength]
app/src/main/java/com/autka/ui/components/ImageUrl.kt:10:5: Function resolveImageUrl has 3 return statements which exceeds the limit of 2. [ReturnCount]
app/src/main/java/com/autka/ui/components/LocalizedNumberParsing.kt:6:14: Function parseLocalizedNonNegativeAmount has 8 return statements which exceeds the limit of 2. [ReturnCount]
app/src/main/java/com/autka/ui/components/LocalizedNumberParsing.kt:74:14: Function parseLocalizedPercentage has 5 return statements which exceeds the limit of 2. [ReturnCount]
app/src/main/java/com/autka/ui/components/LocalizedNumberParsing.kt:101:14: Function isIncompleteLocalizedPercentage has 7 return statements which exceeds the limit of 2. [ReturnCount]
app/src/main/java/com/autka/ui/components/LocalizedNumberParsing.kt:119:14: Function isIncompleteLocalizedAmount has 11 return statements which exceeds the limit of 2. [ReturnCount]
app/src/main/java/com/autka/ui/components/LocalizedNumberParsing.kt:166:14: Function parsePositiveInteger has 4 return statements which exceeds the limit of 2. [ReturnCount]
app/src/main/java/com/autka/ui/components/LocalizedNumberParsing.kt:203:13: Function normalizeGroupedInteger has 10 return statements which exceeds the limit of 2. [ReturnCount]
app/src/main/java/com/autka/ui/components/LocalizedNumberParsing.kt:53:51: This expression contains a magic number. Consider defining it to a well named constant. [MagicNumber]
app/src/main/java/com/autka/ui/components/LocalizedNumberParsing.kt:97:77: This expression contains a magic number. Consider defining it to a well named constant. [MagicNumber]
app/src/main/java/com/autka/ui/components/LocalizedNumberParsing.kt:115:49: This expression contains a magic number. Consider defining it to a well named constant. [MagicNumber]
app/src/main/java/com/autka/ui/components/LocalizedNumberParsing.kt:161:57: This expression contains a magic number. Consider defining it to a well named constant. [MagicNumber]
app/src/main/java/com/autka/ui/components/LocalizedNumberParsing.kt:185:47: This expression contains a magic number. Consider defining it to a well named constant. [MagicNumber]
app/src/main/java/com/autka/ui/components/LocalizedNumberParsing.kt:214:29: This expression contains a magic number. Consider defining it to a well named constant. [MagicNumber]
app/src/main/java/com/autka/ui/components/LocalizedNumberParsing.kt:218:38: This expression contains a magic number. Consider defining it to a well named constant. [MagicNumber]
app/src/main/java/com/autka/ui/components/LocalizedNumberParsing.kt:220:41: This expression contains a magic number. Consider defining it to a well named constant. [MagicNumber]
app/src/main/java/com/autka/ui/components/LocalizedNumberParsing.kt:224:35: This expression contains a magic number. Consider defining it to a well named constant. [MagicNumber]
app/src/main/java/com/autka/ui/theme/Color.kt:6:22: This expression contains a magic number. Consider defining it to a well named constant. [MagicNumber]
app/src/main/java/com/autka/ui/theme/Color.kt:7:26: This expression contains a magic number. Consider defining it to a well named constant. [MagicNumber]
app/src/main/java/com/autka/ui/theme/Color.kt:8:31: This expression contains a magic number. Consider defining it to a well named constant. [MagicNumber]
app/src/main/java/com/autka/ui/theme/Color.kt:9:35: This expression contains a magic number. Consider defining it to a well named constant. [MagicNumber]
app/src/main/java/com/autka/ui/theme/Color.kt:10:19: This expression contains a magic number. Consider defining it to a well named constant. [MagicNumber]
app/src/main/java/com/autka/ui/theme/Color.kt:11:23: This expression contains a magic number. Consider defining it to a well named constant. [MagicNumber]
app/src/main/java/com/autka/ui/theme/Color.kt:12:28: This expression contains a magic number. Consider defining it to a well named constant. [MagicNumber]
app/src/main/java/com/autka/ui/theme/Color.kt:13:32: This expression contains a magic number. Consider defining it to a well named constant. [MagicNumber]
app/src/main/java/com/autka/ui/theme/Color.kt:14:34: This expression contains a magic number. Consider defining it to a well named constant. [MagicNumber]
app/src/main/java/com/autka/ui/theme/Color.kt:16:21: This expression contains a magic number. Consider defining it to a well named constant. [MagicNumber]
app/src/main/java/com/autka/ui/theme/Color.kt:17:26: This expression contains a magic number. Consider defining it to a well named constant. [MagicNumber]
app/src/main/java/com/autka/ui/theme/Color.kt:18:20: This expression contains a magic number. Consider defining it to a well named constant. [MagicNumber]
app/src/main/java/com/autka/ui/theme/Color.kt:19:21: This expression contains a magic number. Consider defining it to a well named constant. [MagicNumber]
app/src/main/java/com/autka/ui/theme/Color.kt:20:26: This expression contains a magic number. Consider defining it to a well named constant. [MagicNumber]
app/src/main/java/com/autka/ui/theme/Color.kt:21:20: This expression contains a magic number. Consider defining it to a well named constant. [MagicNumber]
app/src/main/java/com/autka/ui/theme/Color.kt:23:25: This expression contains a magic number. Consider defining it to a well named constant. [MagicNumber]
app/src/main/java/com/autka/ui/theme/Color.kt:24:26: This expression contains a magic number. Consider defining it to a well named constant. [MagicNumber]
app/src/main/java/com/autka/ui/theme/Color.kt:25:31: This expression contains a magic number. Consider defining it to a well named constant. [MagicNumber]
app/src/main/java/com/autka/ui/theme/Color.kt:26:29: This expression contains a magic number. Consider defining it to a well named constant. [MagicNumber]
app/src/main/java/com/autka/ui/theme/Color.kt:27:34: This expression contains a magic number. Consider defining it to a well named constant. [MagicNumber]
app/src/main/java/com/autka/ui/theme/Color.kt:28:25: This expression contains a magic number. Consider defining it to a well named constant. [MagicNumber]
app/src/main/java/com/autka/ui/theme/Theme.kt:10:41: This expression contains a magic number. Consider defining it to a well named constant. [MagicNumber]
app/src/main/java/com/autka/ui/theme/Theme.kt:11:38: This expression contains a magic number. Consider defining it to a well named constant. [MagicNumber]
app/src/main/java/com/autka/data/remote/mock/MockCarOfferSource.kt:42:1: Line detected, which is longer than the defined maximum line length in the code style. [MaxLineLength]
app/src/main/java/com/autka/data/remote/mock/MockCarOfferSource.kt:53:1: Line detected, which is longer than the defined maximum line length in the code style. [MaxLineLength]
app/src/main/java/com/autka/data/remote/mock/MockCarOfferSource.kt:64:1: Line detected, which is longer than the defined maximum line length in the code style. [MaxLineLength]
app/src/main/java/com/autka/data/remote/mock/MockCarOfferSource.kt:27:15: This expression contains a magic number. Consider defining it to a well named constant. [MagicNumber]
app/src/main/java/com/autka/data/remote/mock/MockCarOfferSource.kt:39:27: This expression contains a magic number. Consider defining it to a well named constant. [MagicNumber]
app/src/main/java/com/autka/data/remote/mock/MockCarOfferSource.kt:43:91: This expression contains a magic number. Consider defining it to a well named constant. [MagicNumber]
app/src/main/java/com/autka/data/remote/mock/MockCarOfferSource.kt:50:27: This expression contains a magic number. Consider defining it to a well named constant. [MagicNumber]
app/src/main/java/com/autka/data/remote/mock/MockCarOfferSource.kt:54:91: This expression contains a magic number. Consider defining it to a well named constant. [MagicNumber]
app/src/main/java/com/autka/data/remote/mock/MockCarOfferSource.kt:61:27: This expression contains a magic number. Consider defining it to a well named constant. [MagicNumber]
app/src/main/java/com/autka/data/remote/mock/MockCarOfferSource.kt:65:91: This expression contains a magic number. Consider defining it to a well named constant. [MagicNumber]
app/src/main/java/com/autka/data/remote/mock/MockCarOfferSource.kt:73:74: This expression contains a magic number. Consider defining it to a well named constant. [MagicNumber]
app/src/main/java/com/autka/data/remote/rates/RateProvider.kt:23:29: This expression contains a magic number. Consider defining it to a well named constant. [MagicNumber]
app/src/main/java/com/autka/data/remote/rates/RateProvider.kt:24:29: This expression contains a magic number. Consider defining it to a well named constant. [MagicNumber]
app/src/main/java/com/autka/data/settings/SettingsRepository.kt:173:17: Function parseSavedSearchDocument has 5 return statements which exceeds the limit of 2. [ReturnCount]
app/src/main/java/com/autka/data/settings/SettingsRepository.kt:191:17: Function decodeSavedSearch has 3 return statements which exceeds the limit of 2. [ReturnCount]
app/src/main/java/com/autka/data/settings/SettingsRepository.kt:313:9: Function toModelOrNull has 7 return statements which exceeds the limit of 2. [ReturnCount]
app/src/main/java/com/autka/data/repository/DefaultExchangeRateRepository.kt:119:25: Function readCached has 3 return statements which exceeds the limit of 2. [ReturnCount]
app/src/main/java/com/autka/di/NetworkModule.kt:43:29: This expression contains a magic number. Consider defining it to a well named constant. [MagicNumber]
app/src/main/java/com/autka/di/NetworkModule.kt:44:26: This expression contains a magic number. Consider defining it to a well named constant. [MagicNumber]
app/src/main/java/com/autka/di/NetworkModule.kt:45:27: This expression contains a magic number. Consider defining it to a well named constant. [MagicNumber]
Analysis failed with 193 weighted issues.
See detailed reports in MegaLinter artifacts
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff
MegaLinter is provided by OX Security
Show us your support by starring ⭐ the repository
🐤 Kanarek · ⚫ closedbranch ⚫
Kanarek, App, Gradle · 8 files |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This is a merge queue draft opened by Mergify. Nobody needs to act on it.
Mergify opened it for batch pink-pontlveque-4wxf7c of the
defaultqueue, to test #241 before it merges intomain. Pushing to this branch or closing this pull request removes #241 from the queue.What this draft tests
Mergify checks that #241 still passes CI once combined with everything queued ahead of it. CI runs on this draft's code, built in this order:
mainat2f494d27a9c1d5The check is speculative: it assumes the pull requests ahead will merge, so it starts without waiting for them.
🎉 Where it stands: checks passed
CI passed on this draft.
Follow the
defaultqueue in the dashboardWhat happens next
mainand closes this draft.Tip
A red check is not necessarily caused by this batch. These checks run on a tip that also carries the commits of the pull request ahead, so a failure here can come from it as much as from #241. See only this batch's changes.
Queued ahead of this batch
This pull request entered the queue before this batch and is not part of it.
Metadata for CI tooling, read by
mergify ciRequired conditions of queue rule
defaultfor mergeNo extra conditions.
Required conditions to stay in the queue
None