feat: chat-anchored monitors & shells with same-turn delivery wire - #1009
Conversation
Protocol: the managed-command queue item gains delivery/targetTurnId and a steering status (all defaulted; the chat.subscribe line carrying the variant is still unshipped, so old rows rehydrate as the next-turn fallback). GUI: the chat becomes the home for its monitors and shells - a floating top-right menu (presence keyed to existence, attention badge acknowledged by opening, rows with lifecycle controls, drag a row out to place or move its output window), the epic sidebar list is gone, the Background panel folds managed rows into its one list with a Stop all that genuinely stops them, and the output window follows the terminal font settings. Signed-off-by: Amiteshwar Randhawa <amiteshwar04@gmail.com>
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
Summary by CodeRabbit
WalkthroughManaged commands move from the Epic sidebar and strip into chat background rows and a chat menu. The change adds attention tracking, aggregate stopping, canvas drag-and-drop, shared terminal font resolution, queue metadata, and persisted-panel normalization. ChangesManaged command surfaces
Estimated code review effort: 4 (Complex) | ~45 minutes Possibly related PRs
Suggested labels: Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b8ee4e2111
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@clients/gui-app/src/components/chat/chat-background-items-panel.tsx`:
- Around line 642-658: Update the stop-all disabled logic and stopAll handler so
each mechanism uses its own capability: keep the button enabled when
managedCommands can be stopped even if canAct is false, and invoke
props.onStopAll only when the chat harness is actionable. Preserve
managed-command mutation independently, and add coverage in
managed-command-chat-surfaces.test.tsx for canAct: false.
In
`@clients/gui-app/src/components/epic-canvas/renderers/__tests__/managed-command-output-tile.test.tsx`:
- Around line 264-292: Update the test helper timeline() to query the rendered
timeline with screen.getByRole("log") instead of its test ID, and keep the
existing font assertions unchanged while binding them to the exposed log
semantics.
In
`@clients/gui-app/src/hooks/managed-command/use-managed-command-lifecycle-mutations.ts`:
- Around line 145-167: Update useManagedCommandStopAll to resolve client once
before Promise.allSettled and fail immediately when unavailable. Preserve a
representative HostRpcError when every stop rejects for the same host error, and
normalize mixed failures to a HostRpcError while retaining the existing
failure-count message. Change onError to call toastFromHostError(error,
error.message).
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: fb358d7e-5e11-4206-aaca-866af7c19270
📒 Files selected for processing (41)
clients/gui-app/src/__tests__/acceptance/managed-command-s5-sidebar.test.tsxclients/gui-app/src/__tests__/acceptance/managed-command-s6-s7-chat-doors.test.tsxclients/gui-app/src/__tests__/acceptance/managed-command-s8-s9-tile-ref-resources.test.tsxclients/gui-app/src/components/chat/__tests__/chat-background-items-panel.test.tsxclients/gui-app/src/components/chat/__tests__/managed-command-chat-surfaces.test.tsxclients/gui-app/src/components/chat/__tests__/queued-message-reorder-dnd.test.tsclients/gui-app/src/components/chat/__tests__/queued-message-surface.test.tsxclients/gui-app/src/components/chat/__tests__/queued-message-utils.test.tsclients/gui-app/src/components/chat/chat-background-items-panel.tsxclients/gui-app/src/components/chat/composer/composer-drag-attachment.tsclients/gui-app/src/components/chat/managed-command-strip-rows.tsxclients/gui-app/src/components/epic-canvas/__tests__/epic-sidebar.test.tsxclients/gui-app/src/components/epic-canvas/__tests__/left-panel-registry.test.tsclients/gui-app/src/components/epic-canvas/__tests__/root-dnd-commits.test.tsclients/gui-app/src/components/epic-canvas/dnd/dnd.tsclients/gui-app/src/components/epic-canvas/dnd/root-dnd-commits.tsclients/gui-app/src/components/epic-canvas/renderers/__tests__/managed-command-output-tile.test.tsxclients/gui-app/src/components/epic-canvas/renderers/chat-tile.tsxclients/gui-app/src/components/epic-canvas/renderers/managed-command-output-tile.tsxclients/gui-app/src/components/epic-canvas/renderers/terminal-tile-xterm.tsxclients/gui-app/src/components/epic-canvas/sidebar/__tests__/managed-command-sidebar.test.tsxclients/gui-app/src/components/epic-canvas/sidebar/epic-sidebar.tsxclients/gui-app/src/components/epic-canvas/sidebar/left-panel-registry.tsclients/gui-app/src/components/epic-canvas/sidebar/managed-command-sidebar.tsxclients/gui-app/src/components/managed-commands/__tests__/managed-command-menu-drag-out.test.tsxclients/gui-app/src/components/managed-commands/managed-command-chat-menu.tsxclients/gui-app/src/components/settings/SETTINGS.mdclients/gui-app/src/components/settings/panels/appearance-settings-panel.tsxclients/gui-app/src/hooks/managed-command/__tests__/use-managed-command-stop-all.test.tsxclients/gui-app/src/hooks/managed-command/use-managed-command-lifecycle-mutations.tsclients/gui-app/src/hooks/settings/use-effective-terminal-font.tsclients/gui-app/src/lib/managed-commands/managed-command-copy.tsclients/gui-app/src/lib/query-keys/managed-command-mutation-keys.tsclients/gui-app/src/stores/chats/__tests__/chat-queue-reconciler.test.tsclients/gui-app/src/stores/chats/__tests__/optimistic-queue.test.tsclients/gui-app/src/stores/chats/__tests__/profile-durability-d1-queue-restamp.test.tsclients/gui-app/src/stores/epics/__tests__/left-panel-store.test.tsclients/gui-app/src/stores/epics/left-panel-store.tsclients/gui-app/src/stores/managed-commands/managed-command-attention-store.tsclients/gui-app/src/stores/managed-commands/managed-command-list-registry.tsprotocol/src/host/agent/gui/subscribe.ts
💤 Files with no reviewable changes (9)
- clients/gui-app/src/components/epic-canvas/sidebar/managed-command-sidebar.tsx
- clients/gui-app/src/components/epic-canvas/sidebar/epic-sidebar.tsx
- clients/gui-app/src/components/epic-canvas/sidebar/left-panel-registry.ts
- clients/gui-app/src/tests/acceptance/managed-command-s5-sidebar.test.tsx
- clients/gui-app/src/components/epic-canvas/sidebar/tests/managed-command-sidebar.test.tsx
- clients/gui-app/src/components/chat/managed-command-strip-rows.tsx
- clients/gui-app/src/components/epic-canvas/tests/epic-sidebar.test.tsx
- clients/gui-app/src/components/epic-canvas/tests/left-panel-registry.test.ts
- clients/gui-app/src/components/epic-canvas/tests/root-dnd-commits.test.ts
Review round: Stop all now offers and sends each of its two halves on that half's own capability, so a reconnecting chat keeps the one-click stop for runaway monitors (the harness half is simply skipped); the aggregated stop fails once with the real host error when no client can be built instead of manufacturing N identical rejections; the output-tile timeline test binds to the exposed log role rather than a test id. Signed-off-by: Amiteshwar Randhawa <amiteshwar04@gmail.com>
|
Review feedback addressed in 60272aa:
Skipped: the 🤖 Generated with Claude Code |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 60272aaf55
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
clients/gui-app/src/hooks/managed-command/use-managed-command-lifecycle-mutations.ts (1)
139-158: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winAdd a dynamic-client variant of
useHostMutation
useHostMutationbindsargs.clientat render time. It cannot select a client fromvariables.hostId. Extend the shared abstraction for per-mutation client resolution, then use it here. PreservewithHostMutationLifecycleBoundaryandtoastFromHostErrorinstead of usingtoast.error.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@clients/gui-app/src/hooks/managed-command/use-managed-command-lifecycle-mutations.ts` around lines 139 - 158, Extend useHostMutation to resolve the HostClient from mutation variables at execution time, while retaining withHostMutationLifecycleBoundary and toastFromHostError behavior. Update the managedCommand stopAll mutation to use this dynamic-client variant with variables.hostId instead of manually constructing the client and handling its unavailable error. Preserve the existing stop-all request and settled-outcome behavior.Sources: Coding guidelines, Learnings
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@clients/gui-app/src/components/chat/__tests__/managed-command-chat-surfaces.test.tsx`:
- Around line 584-585: Update the Stop all button assertions in the
managed-command chat surface tests to query the button by role with the
accessible name “Stop all” instead of using the background-stop-all test ID.
Assert its native disabled state through the HTMLButtonElement.disabled
property, including the corresponding assertion around the later test case.
---
Outside diff comments:
In
`@clients/gui-app/src/hooks/managed-command/use-managed-command-lifecycle-mutations.ts`:
- Around line 139-158: Extend useHostMutation to resolve the HostClient from
mutation variables at execution time, while retaining
withHostMutationLifecycleBoundary and toastFromHostError behavior. Update the
managedCommand stopAll mutation to use this dynamic-client variant with
variables.hostId instead of manually constructing the client and handling its
unavailable error. Preserve the existing stop-all request and settled-outcome
behavior.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 8fbe031a-d28c-4f55-b8aa-726e7f96228d
📒 Files selected for processing (4)
clients/gui-app/src/components/chat/__tests__/managed-command-chat-surfaces.test.tsxclients/gui-app/src/components/chat/chat-background-items-panel.tsxclients/gui-app/src/components/epic-canvas/renderers/__tests__/managed-command-output-tile.test.tsxclients/gui-app/src/hooks/managed-command/use-managed-command-lifecycle-mutations.ts
… in tests A managed-command chip in the new steering state locked its controls with no visible reason - the label logic still assumed only pending|paused could occur. The handover window now reads "Delivering", so the closed cancel lever explains itself. The new Stop all assertions bind to the button's role and accessible name per house guidelines. Signed-off-by: Amiteshwar Randhawa <amiteshwar04@gmail.com>
|
Second round addressed in 4d466aa:
🤖 Generated with Claude Code |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4d466aa3a8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…ments Signed-off-by: Amiteshwar Randhawa <amiteshwar04@gmail.com> # Conflicts: # clients/gui-app/src/__tests__/acceptance/managed-command-s5-sidebar.test.tsx # clients/gui-app/src/__tests__/acceptance/managed-command-s8-s9-tile-ref-resources.test.tsx # clients/gui-app/src/components/epic-canvas/sidebar/__tests__/managed-command-sidebar.test.tsx
The badge floated over the transcript's top-right corner, which put it where the reading happens and gave it a plate of its own to stay legible over live text. It now sits in the workspace-controls row under the composer, next to the host, workspace and context-usage chips - the other per-chat facts a person checks between turns - and wears their styling: no plate, no border, dimmed until hovered, popover opening upward. It rides the row's leading cell rather than becoming a third grid column: the usage chip's pinned breakdown spans the row with `col-span-full`, which only works while it is a direct child of ComposerWorkspaceRow's two-column grid. `justify-between` parks the menu at that cell's trailing edge, so it reads as the chip's left-hand neighbour and the workspace selector gives up width first when the row is tight. Presence rule is unchanged: nothing renders while the chat owns no commands, and the menu never unmounts under an open popover. Signed-off-by: Amiteshwar Randhawa <amiteshwar04@gmail.com>
b8ee4e2 taught BackgroundItemsPanel to read the tile's bound host and to mint a managed-command "Stop all" mutation, but four suites that render it still stood outside <TabHostProvider> or mocked the lifecycle-mutations module without `useManagedCommandStopAll`; the chat-tile suites likewise mocked the stream-runtime context without the support probe the monitors menu makes. Each render threw where the panel used to be inert. Signed-off-by: Amiteshwar Randhawa <amiteshwar04@gmail.com>
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
Pushed 0353601 (with the
🤖 Generated with Claude Code |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 03536019f0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Actionable comments posted: 5
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@clients/gui-app/src/components/chat/__tests__/managed-command-chat-surfaces.test.tsx`:
- Around line 611-615: Update the Stop Command assertion in the managed-command
chat surface test to cast the queried button to HTMLButtonElement and assert its
native disabled property, matching the neighboring Stop-all assertions; do not
inspect the raw disabled attribute.
In `@clients/gui-app/src/components/chat/queued-message-surface.tsx`:
- Around line 830-834: Update the pulse's assistive label in the queued-message
surface to derive from props.label instead of using the hardcoded “Steering
queued message” text, so it matches the visible “Delivering” state returned for
steering items by the status-label logic.
In
`@clients/gui-app/src/components/managed-commands/managed-command-chat-menu.tsx`:
- Around line 125-147: Update the managed-command menu trigger’s accessible name
to include clear attention and running count labels, preserving the existing
“Monitors and shells” context and handling zero counts appropriately. Mark the
rendered count text in ManagedCommandMenuBadge as aria-hidden so screen readers
announce the labeled counts only once.
In
`@clients/gui-app/src/hooks/managed-command/__tests__/use-managed-command-stop-all.test.tsx`:
- Around line 31-34: Add a test in the use-managed-command stop-all suite that
configures the mocked useHostDirectory().findById to return null, then verifies
no stop RPC is sent and exactly one unavailable-host error toast is emitted.
Preserve the existing mock behavior and assertions for available hosts.
In `@clients/gui-app/src/hooks/settings/use-effective-terminal-font.ts`:
- Line 25: Rename useEffectiveTerminalFont to follow the
use<Namespace><Verb><Noun> convention, such as useSettingsResolveTerminalFont,
and update every caller and import to use the new name consistently.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 7795b220-264d-4a37-9bb3-ded05dcec15e
📒 Files selected for processing (47)
clients/gui-app/src/__tests__/acceptance/managed-command-s5-sidebar.test.tsxclients/gui-app/src/__tests__/acceptance/managed-command-s6-s7-chat-doors.test.tsxclients/gui-app/src/__tests__/acceptance/managed-command-s8-s9-tile-ref-resources.test.tsxclients/gui-app/src/components/chat/__tests__/chat-background-items-panel.test.tsxclients/gui-app/src/components/chat/__tests__/chat-lower-dock.test.tsxclients/gui-app/src/components/chat/__tests__/chat-scrollbar-composer-overlay.test.tsxclients/gui-app/src/components/chat/__tests__/managed-command-chat-surfaces.test.tsxclients/gui-app/src/components/chat/__tests__/queued-message-reorder-dnd.test.tsclients/gui-app/src/components/chat/__tests__/queued-message-surface.test.tsxclients/gui-app/src/components/chat/__tests__/queued-message-utils.test.tsclients/gui-app/src/components/chat/chat-background-items-panel.tsxclients/gui-app/src/components/chat/composer/composer-drag-attachment.tsclients/gui-app/src/components/chat/managed-command-strip-rows.tsxclients/gui-app/src/components/chat/queued-message-surface.tsxclients/gui-app/src/components/epic-canvas/__tests__/chat-tile-queue-edit-steer.test.tsxclients/gui-app/src/components/epic-canvas/__tests__/chat-tile.test.tsxclients/gui-app/src/components/epic-canvas/__tests__/epic-sidebar.test.tsxclients/gui-app/src/components/epic-canvas/__tests__/left-panel-registry.test.tsclients/gui-app/src/components/epic-canvas/__tests__/root-dnd-commits.test.tsclients/gui-app/src/components/epic-canvas/dnd/dnd.tsclients/gui-app/src/components/epic-canvas/dnd/root-dnd-commits.tsclients/gui-app/src/components/epic-canvas/renderers/__tests__/chat-lower-background-spacing.test.tsxclients/gui-app/src/components/epic-canvas/renderers/__tests__/managed-command-output-tile.test.tsxclients/gui-app/src/components/epic-canvas/renderers/chat-tile.tsxclients/gui-app/src/components/epic-canvas/renderers/managed-command-output-tile.tsxclients/gui-app/src/components/epic-canvas/renderers/terminal-tile-xterm.tsxclients/gui-app/src/components/epic-canvas/sidebar/__tests__/managed-command-sidebar.test.tsxclients/gui-app/src/components/epic-canvas/sidebar/epic-sidebar.tsxclients/gui-app/src/components/epic-canvas/sidebar/left-panel-registry.tsclients/gui-app/src/components/epic-canvas/sidebar/managed-command-sidebar.tsxclients/gui-app/src/components/managed-commands/__tests__/managed-command-menu-drag-out.test.tsxclients/gui-app/src/components/managed-commands/managed-command-chat-menu.tsxclients/gui-app/src/components/settings/SETTINGS.mdclients/gui-app/src/components/settings/panels/appearance-settings-panel.tsxclients/gui-app/src/hooks/managed-command/__tests__/use-managed-command-stop-all.test.tsxclients/gui-app/src/hooks/managed-command/use-managed-command-lifecycle-mutations.tsclients/gui-app/src/hooks/settings/use-effective-terminal-font.tsclients/gui-app/src/lib/managed-commands/managed-command-copy.tsclients/gui-app/src/lib/query-keys/managed-command-mutation-keys.tsclients/gui-app/src/stores/chats/__tests__/chat-queue-reconciler.test.tsclients/gui-app/src/stores/chats/__tests__/optimistic-queue.test.tsclients/gui-app/src/stores/chats/__tests__/profile-durability-d1-queue-restamp.test.tsclients/gui-app/src/stores/epics/__tests__/left-panel-store.test.tsclients/gui-app/src/stores/epics/left-panel-store.tsclients/gui-app/src/stores/managed-commands/managed-command-attention-store.tsclients/gui-app/src/stores/managed-commands/managed-command-list-registry.tsprotocol/src/host/agent/gui/subscribe.ts
💤 Files with no reviewable changes (9)
- clients/gui-app/src/components/epic-canvas/tests/left-panel-registry.test.ts
- clients/gui-app/src/components/epic-canvas/sidebar/managed-command-sidebar.tsx
- clients/gui-app/src/components/epic-canvas/sidebar/epic-sidebar.tsx
- clients/gui-app/src/components/epic-canvas/tests/epic-sidebar.test.tsx
- clients/gui-app/src/components/chat/managed-command-strip-rows.tsx
- clients/gui-app/src/components/epic-canvas/tests/root-dnd-commits.test.ts
- clients/gui-app/src/tests/acceptance/managed-command-s5-sidebar.test.tsx
- clients/gui-app/src/components/epic-canvas/sidebar/tests/managed-command-sidebar.test.tsx
- clients/gui-app/src/components/epic-canvas/sidebar/left-panel-registry.ts
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 696d3c8434
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…l rule The delete confirmation survives its popover (same focus-outside guard as the notifications bell); the popover caps to the viewport and scrolls; the trigger's accessible name carries what its counts count; drag ids are unique per mounted row so the same chat open twice cannot cross wires; endings that arrive while the menu is open count as seen; the delivery pulse announces the visible label; Stop all is one button with one in-flight state; plus unavailable-host coverage and native disabled assertions. Signed-off-by: Amiteshwar Randhawa <amiteshwar04@gmail.com>
|
Third round addressed in b46b38d:
Skipped, with reasons: the 🤖 Generated with Claude Code |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9567177a9e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The same chat can be open in two canvas tiles, and each panel owned its own mutation observer - the second tile's button stayed live while the first tile's batch ran and could re-submit the same command ids. The button now reads the batch's in-flight state through useIsMutating, shared across every mounted panel. Signed-off-by: Amiteshwar Randhawa <amiteshwar04@gmail.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e5b8823928
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…h state The shared pending read exists for the same chat open in two tiles - an app-wide key let one chat's batch disable every other chat's button, so the mutation key now carries the chat id. Per-row stops also go dead during the batch: a row press mid-batch re-sent a stop the batch already carries. Signed-off-by: Amiteshwar Randhawa <amiteshwar04@gmail.com>
Gated at the shared lifecycle action - which reads the batch state off the command's own chat id - so the menu row, the output window, and the panel row follow one rule instead of each surface re-implementing it; the panel's own belt-and-suspenders hiding rule collapses away. Signed-off-by: Amiteshwar Randhawa <amiteshwar04@gmail.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 29b7149971
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
A digest aimed at the running turn read identically to a next-turn one; "Will deliver" - the delivery-vocabulary sibling of the prompt rows' "Will steer" - tells the user the cancel window is the current turn. Signed-off-by: Amiteshwar Randhawa <amiteshwar04@gmail.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b959be71ef
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
On "keep the unsupported-host notice reachable" — deliberately not taken. A host too old for 🤖 Generated with Claude Code |
…m is gone The standalone managedCommand.subscribeList existed to serve a global panel that no longer exists; every consumer is chat-scoped. chat.subscribe snapshots now carry managedCommands (default [], never null-checked - an old host and an empty chat both truthfully read as none) and a dedicated whole-set managedCommandsChanged frame carries updates, deliberately not riding turnStateChanged because a command's lifecycle is not a turn transition. Because chat.subscribe is tab-host-bound, a chat tile now reads its own host's commands by construction - the cross-host defect where a tile bound to one host rendered another host's list is unrepresentable. The list stream mount, store, registry, factory override, stale-list plumbing and the menu's now-unrepresentable host-too-old branch are deleted; the re-entry path for a future epic-wide list is documented where the method lived. Output-window tab titles narrow: with no epic-wide list, a window whose owning chat has no live session falls back to its persisted name until one opens. Signed-off-by: Amiteshwar Randhawa <amiteshwar04@gmail.com>
|
Architecture change (product-owner directed): managed commands now ride the chat stream; the epic list stream is deleted (3a85baf here, be467ff339 internal).
This resolves the cross-host P1 by construction: chat.subscribe is tab-host-bound, so a chat tile reads its own host's commands — the mixed shape (app-wide stream feeding a tile-bound control) no longer exists. The list mount/store/registry/factory and stale-list plumbing are deleted; a future global panel's re-entry path is documented where the method lived (the epic-activity dual-plane is the intended rail for cross-host ambient summaries). Known narrowing: an output window whose owning chat has no live session falls back to its persisted tab name until one opens. Follow-ups noted for a later PR: an exhaustiveness guard on the chat-stream client's frame switch (its absence let a new frame kind be silently dropped — caught and probed during this migration), and the output tile's capability check reading the app-wide client ( 🤖 Generated with Claude Code |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3a85baf1d2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
On "read resource stats from the tile-bound host" — valid, deferred to the cross-host follow-up alongside its two siblings (the output tile's capability check, and the chat-stream client exhaustiveness guard). The command list itself is now tab-host-bound by construction; the resource chips still join against the app-wide resources registry, so on the rare cross-host tile a chip goes ABSENT (a foreign command id misses the active host's snapshot) — which is the resources design's stated preference over a wrong or zero readout, and the readouts are opt-in. Re-scoping the resources stream per host reshapes a surface the app-level resources popover also rides, so it belongs to the resources work package, not this PR. 🤖 Generated with Claude Code |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f442aec693
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…r policy A batch that failed entirely almost always failed for one systemic reason (revoked access, host gone, unsupported method). The typed error is thrown and rendered by the standard policy - recoverable-unauthorized suppression, upgrade/reconnect guidance, dedup - exactly as the per-row path does; the count summary stays for partial failures with mixed causes. Signed-off-by: Amiteshwar Randhawa <amiteshwar04@gmail.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 362c46d574
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
On "key managed-command chat slices by host" — refuted after verification, no change. The premise ("cross-host clones retain the same epic/chat in tabs bound to different hosts") is not a reachable state: clone-not-migrate creates a SIBLING chat with a new id on the target host ( 🤖 Generated with Claude Code |
1 participant
What
The chat becomes the home for its monitors and shells, and the queue-item wire gains same-turn delivery fields.
Protocol (
chat.subscribe, still-unshipped 1.6 line — no version ritual needed, verified absent from all release tags):delivery/targetTurnIdand asteeringstatus, all defaulted so rows written by earlier builds rehydrate as the next-turn fallback.GUI:
Review
Built by two independent implementation rounds, then an adversarial review (probe tests, not inspection) that confirmed 8 defects — including drag-out being a complete no-op due to popover unmount killing the dnd payload, and the sidebar-layout upgrade reset — followed by a fix round in which every fix landed with the test that would have caught it, proof-of-red verified.
Validation
Targeted suites green (drag/pointer-gesture suite included), gui-app compile, ESLint, Prettier, react-doctor all clean. Known residual: drag-out deserves one manual browser pass (jsdom can't fully prove the pointer gesture).
🤖 Generated with Claude Code