Repository navigation
fix(gui-app): stop restore toast replay across task tabs - #865
Conversation
Signed-off-by: Hardik Shingala <hardik@traycer.ai>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI (base), Organization UI (inherited) Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
Summary by CodeRabbit
WalkthroughThe change moves restore-result toast delivery into a dedicated pane-aware component. It tracks delivered completions per chat session, limits retained keys, removes the previous chat-tile focus effect, and adds coverage for deferred, deduplicated, and distinct restore completions. ChangesRestore toast delivery
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Summary
Root cause
Completed restore state intentionally persists after the operation finishes. The toast was emitted from an active-pane effect that re-runs whenever the pane regains focus, so every task-tab shuffle replayed the same completed result.
The new focused-pane toast bridge keys each completion by checkpoint and finish time and records delivery in a bounded per-session set outside React component state. That keeps the one-shot marker alive across tab changes and remounts without consuming the restore state the dialog still needs.
Related issue
None.
Verification
Checklist
bun run build,bun run lint, andbun run testpass (CI owns the broad suites)